chore: adds disable SNI on provider API request#136
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #136 +/- ##
=======================================
Coverage 70.13% 70.13%
=======================================
Files 23 23
Lines 864 864
Branches 221 221
=======================================
Hits 606 606
Misses 244 244
Partials 14 14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
stalniy
force-pushed
the
fix/disable-sni-example
branch
from
54aae54 to
83e9986
Compare
stalniy
force-pushed
the
fix/disable-sni-example
branch
from
83e9986 to
16dafa1
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR adds configuration to disable Server Name Indication (SNI) for HTTPS connections to provider APIs, enabling proper mTLS authentication with self-signed certificates. The changes ensure that provider API communication uses the correct SSL/TLS handshake process for authenticating with blockchain-based providers.
- Adds
servername: ""configuration to disable SNI in HTTPS agent setup - Includes explanatory comments about the necessity of disabling SNI for mTLS authentication
- Adds comprehensive documentation explaining provider API communication requirements
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| examples/create_deployment.ts | Updates HTTPS agent configuration to disable SNI with explanatory comment |
| examples/README.md | Adds detailed documentation section explaining provider API communication and certificate handling |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| cert: certificate.cert, | ||
| key: certificate.privateKey, | ||
| rejectUnauthorized: false, // provider API responds with self-signed certificate but it needs to be verified manually! | ||
| servername: "" // required to disable SNI, so the provider API will use mTLS authentication (e.i., self-signed certificates) |
There was a problem hiding this comment.
Corrected 'e.i.' to 'i.e.' (id est, meaning 'that is').
| servername: "" // required to disable SNI, so the provider API will use mTLS authentication (e.i., self-signed certificates) | |
| servername: "" // required to disable SNI, so the provider API will use mTLS authentication (i.e., self-signed certificates) |
| key: certificate.privateKey, | ||
| rejectUnauthorized: false | ||
| rejectUnauthorized: false, // provider API responds with self-signed certificate but it needs to be verified manually! | ||
| servername: "" // required to disable SNI, so the provider API will use mTLS authentication (e.i., self-signed certificates) |
There was a problem hiding this comment.
Corrected 'e.i.' to 'i.e.' (id est, meaning 'that is').
| servername: "" // required to disable SNI, so the provider API will use mTLS authentication (e.i., self-signed certificates) | |
| servername: "" // required to disable SNI, so the provider API will use mTLS authentication (i.e., self-signed certificates) |
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
No description provided.