Skip to content
This repository was archived by the owner on Feb 23, 2026. It is now read-only.

fix: disable SNI for mtls#135

Closed
Zblocker64 wants to merge 3 commits intomainfrom
disbale-SNI
Closed

fix: disable SNI for mtls#135
Zblocker64 wants to merge 3 commits intomainfrom
disbale-SNI

Conversation

@Zblocker64
Copy link

@Zblocker64 Zblocker64 commented Sep 18, 2025

This PR disables SNI when sending the manifest to the provider while using mTLS as authentication method. This is because with provider services version 0.8.0 or higher, the provider rejects it if SNI is set but no JWT token provided.

@codecov-commenter
Copy link

codecov-commenter commented Sep 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.13%. Comparing base (3e957ce) to head (82d4cee).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #135   +/-   ##
=======================================
  Coverage   70.13%   70.13%           
=======================================
  Files          23       23           
  Lines         864      864           
  Branches      221      224    +3     
=======================================
  Hits          606      606           
- Misses        244      257   +13     
+ Partials       14        1   -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Zblocker64
Copy link
Author

Fixes akash-network/support#370

@Zblocker64 Zblocker64 changed the title fix: disable SNI fix: disable SNI for mtls Sep 18, 2025
@baktun14
Copy link
Contributor

This is what was done in the provider proxy to fix the SNI issue akash-network/console#1667

@stalniy
Copy link
Contributor

stalniy commented Oct 3, 2025

close in favor of #136

@stalniy stalniy closed this Oct 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants