add CLI interface for USBCopySession with resume() support - #6
Merged
Conversation
yuya-haruna
reviewed
Dec 2, 2025
| ] | ||
|
|
||
| [project.scripts] | ||
| airoa-usb-copy = "airoa_lineage.cli.usb_copy:main" |
There was a problem hiding this comment.
コマンド名の意味が広すぎるかなと思いました。
長くなってしまいますが、 airoa-lineage-usb-copy などはいかがでしょうか。
（airoa-usb-copyだと、usbにcopyするコマンドのように見えてしまい）
| help="Show what would be done without executing", | ||
| ) | ||
|
|
||
| # COMPLETE command |
There was a problem hiding this comment.
STARTと同様に、必要なFacetsは全てコマンドライン引数で渡せるようにしていただけますでしょうか。
このCLIを叩く、autouploaderはREADME.mdを読む限りバイナリを配布しているような感じらしく、コミットのハッシュ値などをアップデートのたびにconfigに反映してもらうのは運用的に難しいかなと思いました。
そのため、バイナリに必要な値は埋め込んでおいて、それをcliに直接渡して通知できる仕様の方が良い気がしました。
（configの機能自体は持っておいても良いとは思います）
Contributor
Author
|
@yuya-haruna |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue リンク / Link to Issue
https://github.com/airoa-org/hsr_devops/issues/114
やったこと / What I did
やってないこと / What I did not
チェック観点 / Check Points
補足 / Supplement