-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
destination-dev-null: merge cloud and OSS #45651
base: stephane/09-18-destination-e2e_upgrade_cdk
Are you sure you want to change the base?
destination-dev-null: merge cloud and OSS #45651
Conversation
The latest updates on your projects. Learn more about Vercel for Git βοΈ
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @stephane-airbyte and the rest of your teammates on Graphite |
22217be
to
3d27a3b
Compare
95cc53d
to
5bf6469
Compare
3d27a3b
to
4d46537
Compare
5bf6469
to
25bde21
Compare
4d46537
to
236bd09
Compare
@@ -2,7 +2,7 @@ data: | |||
connectorSubtype: unknown | |||
connectorType: destination | |||
definitionId: 2eb65e87-983a-4fd7-b3e3-9d9dc6eb8537 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to clarify, if we drop the cloud version but don't change the definitionId or name of the oss version, then we effectively create a new cloud connector with a new name? That is what we want? All existing connections using dev-null will just be parked at the old version until they switch over?
25bde21
to
0844477
Compare
236bd09
to
99cab00
Compare
99cab00
to
4f03511
Compare
0844477
to
ba0b812
Compare
4f03511
to
b43ab0e
Compare
ba0b812
to
11a40c5
Compare
b43ab0e
to
2148679
Compare
afa13f1
to
8843925
Compare
0af4c79
to
5e96375
Compare
8843925
to
9d66c12
Compare
5e96375
to
2946cca
Compare
9d66c12
to
a657ecb
Compare
a657ecb
to
00b415b
Compare
2946cca
to
8a624a3
Compare
00b415b
to
77d7133
Compare
@@ -42,6 +48,33 @@ constructor( | |||
] | |||
} | |||
|
|||
override fun spec(): ConnectorSpecification { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this backwards? You remove everything but silent
from the !isCloudDeployment version
/** 1. Update the title. 2. Only keep the "silent" mode. */ | ||
val spec = super.spec() | ||
|
||
(spec.connectionSpecification as ObjectNode).put("title", DEV_NULL_DESTINATION_TITLE) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the cloud title also?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess I fucked that one up? I reverted them. I'll fix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually, why should we use different names, now that they're the same connector?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
π€· Minimal disruption? Keeping parity with what exists?
6d53ad2
to
77508cb
Compare
77508cb
to
b665715
Compare
b665715
to
0945d13
Compare
0945d13
to
7b34c61
Compare
What
How
Review guide
User Impact
Can this PR be safely reverted and rolled back?