Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

destination-dev-null: convert test code to kotlin #45649

Merged
merged 1 commit into from
Sep 20, 2024
Merged

destination-dev-null: convert test code to kotlin #45649

merged 1 commit into from
Sep 20, 2024

Conversation

stephane-airbyte
Copy link
Contributor

What

How

Review guide

User Impact

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

@vercel Vercel
Copy link

vercel bot commented Sep 18, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 20, 2024 9:25pm

@stephane-airbyte Graphite App
Copy link
Contributor Author

stephane-airbyte commented Sep 18, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @stephane-airbyte and the rest of your teammates on Graphite Graphite

@stephane-airbyte stephane-airbyte mentioned this pull request Sep 18, 2024
Merged
2 tasks
@stephane-airbyte stephane-airbyte force-pushed the stephane/09-18-destination-e2e_convert_production_code_to_kotlin branch from 90a6478 to 327bf4c Compare September 18, 2024 14:43
@stephane-airbyte stephane-airbyte force-pushed the stephane/09-18-destination-e2e_convert_test_code_to_kotlin branch from cada42a to b72514f Compare September 18, 2024 14:43
This was referenced Sep 18, 2024
Merged
Merged
@stephane-airbyte stephane-airbyte force-pushed the stephane/09-18-destination-e2e_convert_production_code_to_kotlin branch from 327bf4c to 6269c86 Compare September 18, 2024 15:49
@stephane-airbyte stephane-airbyte force-pushed the stephane/09-18-destination-e2e_convert_test_code_to_kotlin branch from b72514f to 47465d2 Compare September 18, 2024 15:49
@stephane-airbyte stephane-airbyte force-pushed the stephane/09-18-destination-e2e_convert_test_code_to_kotlin branch from 47465d2 to 2a6c653 Compare September 18, 2024 17:38
@stephane-airbyte stephane-airbyte force-pushed the stephane/09-18-destination-e2e_convert_test_code_to_kotlin branch from 2a6c653 to 46fbf61 Compare September 18, 2024 18:07
@stephane-airbyte stephane-airbyte force-pushed the stephane/09-18-destination-e2e_convert_test_code_to_kotlin branch from 46fbf61 to d4ac3e2 Compare September 18, 2024 18:15
@stephane-airbyte stephane-airbyte force-pushed the stephane/09-18-destination-e2e_convert_production_code_to_kotlin branch from 6269c86 to 283ec05 Compare September 18, 2024 20:05
@stephane-airbyte stephane-airbyte force-pushed the stephane/09-18-destination-e2e_convert_test_code_to_kotlin branch from d4ac3e2 to 14af288 Compare September 18, 2024 20:05
@stephane-airbyte stephane-airbyte force-pushed the stephane/09-18-destination-e2e_convert_production_code_to_kotlin branch from 283ec05 to b64a103 Compare September 18, 2024 21:13
@stephane-airbyte stephane-airbyte force-pushed the stephane/09-18-destination-e2e_convert_test_code_to_kotlin branch from 14af288 to 9024b73 Compare September 18, 2024 21:13
@stephane-airbyte stephane-airbyte force-pushed the stephane/09-18-destination-e2e_convert_production_code_to_kotlin branch from b64a103 to 487e307 Compare September 18, 2024 21:47
@stephane-airbyte stephane-airbyte force-pushed the stephane/09-18-destination-e2e_convert_test_code_to_kotlin branch from 9024b73 to 9eed945 Compare September 18, 2024 21:47
@stephane-airbyte stephane-airbyte force-pushed the stephane/09-18-destination-e2e_convert_production_code_to_kotlin branch from 487e307 to df71ae2 Compare September 18, 2024 21:57
@stephane-airbyte stephane-airbyte force-pushed the stephane/09-18-destination-e2e_convert_test_code_to_kotlin branch from 9eed945 to 73daae8 Compare September 18, 2024 21:57
@stephane-airbyte stephane-airbyte changed the title destination-e2e: convert test code to kotlin destination-dev-null: convert test code to kotlin Sep 18, 2024
@stephane-airbyte stephane-airbyte force-pushed the stephane/09-18-destination-e2e_convert_production_code_to_kotlin branch from df71ae2 to ecde255 Compare September 18, 2024 22:46
@stephane-airbyte stephane-airbyte force-pushed the stephane/09-18-destination-e2e_convert_test_code_to_kotlin branch from 73daae8 to dd065cd Compare September 18, 2024 22:46
@stephane-airbyte stephane-airbyte marked this pull request as ready for review September 18, 2024 23:38
@stephane-airbyte stephane-airbyte requested a review from a team as a code owner September 18, 2024 23:38
@stephane-airbyte Graphite App
Copy link
Contributor Author

stephane-airbyte commented Sep 20, 2024 •
edited
Loading

Merge activity

  • Sep 20, 2:05 PM EDT: @stephane-airbyte started a stack merge that includes this pull request via Graphite.
  • Sep 20, 2:08 PM EDT: Graphite rebased this pull request as part of a merge.
  • Sep 20, 2:21 PM EDT: Graphite couldn't merge this PR because it was not satisfying all requirements (Failed CI: 'Gradle Check').

@stephane-airbyte stephane-airbyte changed the base branch from stephane/09-18-destination-e2e_convert_production_code_to_kotlin to graphite-base/45649 September 20, 2024 18:06
@stephane-airbyte stephane-airbyte changed the base branch from graphite-base/45649 to master September 20, 2024 18:06
@stephane-airbyte stephane-airbyte force-pushed the stephane/09-18-destination-e2e_convert_test_code_to_kotlin branch 2 times, most recently from d55373f to 142408b Compare September 20, 2024 18:08
@stephane-airbyte stephane-airbyte mentioned this pull request Sep 20, 2024
Merged
2 tasks
@stephane-airbyte stephane-airbyte force-pushed the stephane/09-18-destination-e2e_convert_test_code_to_kotlin branch from 142408b to 1cffd92 Compare September 20, 2024 20:07
@stephane-airbyte stephane-airbyte force-pushed the stephane/09-18-destination-e2e_convert_test_code_to_kotlin branch from 1cffd92 to 440cfa3 Compare September 20, 2024 21:20
@stephane-airbyte stephane-airbyte merged commit c6ec55d into master Sep 20, 2024
36 checks passed
@stephane-airbyte stephane-airbyte deleted the stephane/09-18-destination-e2e_convert_test_code_to_kotlin branch September 20, 2024 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnny-schmidt johnny-schmidt johnny-schmidt approved these changes

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/destination/dev-null connectors/destination/e2e-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stephane-airbyte @johnny-schmidt @octavia-squidington-iii