Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Relocates self._extract_slice_fields(stream_slice=stream_slice) within conditional codeblock that uses it. #304

Merged
merged 2 commits into from
Jan 31, 2025
+1 −2
Merged

fix: Relocates self._extract_slice_fields(stream_slice=stream_slice) within conditional codeblock that uses it. #304

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d502b8e
update _read_pages
pnilan Jan 30, 2025
b0da2b8
chore: format code
pnilan Jan 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Loading
Loading status checks…
chore: format code
@pnilan
pnilan committed Jan 30, 2025
commit b0da2b8040de6d2dc38b653f5704e3d1d753cffb
1 change: 0 additions & 1 deletion airbyte_cdk/sources/streams/http/http.py
View file
Original file line number Diff line number Diff line change
@@ -423,7 +423,6 @@ def _read_pages(
stream_slice: Optional[Mapping[str, Any]] = None,
stream_state: Optional[Mapping[str, Any]] = None,
) -> Iterable[StreamData]:

stream_state = stream_state or {}
pagination_complete = False
next_page_token = None