fix: update HttpStream._read_pages to support custom stream slice

[pnilan]

What

• Moves the invocation of self._extract_slice_fields within conditional code block
• Enables steams w/ custom stream slice implementations to still function properly

Summary by CodeRabbit

• Bug Fixes
  • Improved stream pagination handling for more robust cursor management during data synchronization.

[coderabbitai]

📝 Walkthrough

Walkthrough

The changes involve a minor modification to the _read_pages method in the HttpStream class within the Airbyte CDK's HTTP stream implementation. A new line is added to extract slice fields, specifically focusing on capturing the partition information when working with a SubstreamResumableFullRefreshCursor. This change aims to improve the handling of substream partitions during the pagination process, ensuring more robust cursor state management.

Changes

File	Change Summary
airbyte_cdk/sources/streams/http/http.py	Added line to extract partition from stream slice in _read_pages method

Sequence Diagram

sequenceDiagram
    participant Stream as HttpStream
    participant Cursor as SubstreamResumableFullRefreshCursor
    
    Stream->>Cursor: _read_pages method
    Stream->>Stream: _extract_slice_fields(stream_slice)
    Stream-->>Stream: Capture partition information
    Stream->>Cursor: Continue pagination process

Loading

The sequence diagram illustrates the enhanced flow of extracting partition information during the stream reading process, highlighting the new line's role in capturing additional context from the stream slice.

What do you think about the clarity of the diagram? Would you like to add any more details to it?

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d502b8e and b0da2b8.

📒 Files selected for processing (1)

• airbyte_cdk/sources/streams/http/http.py (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• airbyte_cdk/sources/streams/http/http.py

⏰ Context from checks skipped due to timeout of 90000ms (5)

• GitHub Check: Pytest (All, Python 3.11, Ubuntu)
• GitHub Check: Pytest (Fast)
• GitHub Check: preview_docs
• GitHub Check: MyPy Check
• GitHub Check: Pytest (All, Python 3.10, Ubuntu)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.