update dependency and add demo for consul2istio #11
tanjunchenci.yaml
on: pull_request
build and test
1m 37s
golangci-lint
1m 0s
gofmt and goimports
30s
check go.mod and go.sum
16s
Annotations
8 errors and 6 warnings
|
gofmt and goimports
Process completed with exit code 127.
|
|
golangci-lint:
pkg/serviceregistry/consul/conversion.go#L143
S1025: the argument is already a string, there's no need to use fmt.Sprintf (gosimple)
|
|
golangci-lint:
pkg/controller.go#L202
copylocks: literal copies lock value from *new: istio.io/api/networking/v1alpha3.ServiceEntry contains google.golang.org/protobuf/internal/impl.MessageState contains sync.Mutex (govet)
|
|
golangci-lint
issues found
|
|
build and test
serviceHostname() => "productpage", want "productpage.service.consul"
|
|
build and test
convertWorkloadEntry() => 0, want UDP
|
|
build and test
converServiceEntry() => udp-9080, want udp
|
|
build and test
Process completed with exit code 1.
|
|
check go.mod and go.sum
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/setup-go@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
gofmt and goimports
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/setup-go@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
golangci-lint
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, golangci/golangci-lint-action@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
golangci-lint
The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
golangci-lint
The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
build and test
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/setup-go@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|