update dependency and add demo for consul2istio #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanjunchen
commented
Jul 28, 2023
| istio.io/api v0.0.0-20230518153929-d0aebaa77ab8 | ||
| istio.io/client-go v1.16.4-0.20230518154329-f75cb9ff8e52 | ||
| istio.io/istio v0.0.0-20230519000352-ae8d5164776c | ||
| istio.io/pkg v0.0.0-20221107183613-574f8d141535 |
tanjunchen
force-pushed
the
master
branch
3 times, most recently
from
20deada
to
fb66599
Compare
Signed-off-by: zhaohuabing <[email protected]> Signed-off-by: chentanjun <[email protected]>
tanjunchen
force-pushed
the
master
branch
9 times, most recently
from
78460b7
to
7374427
Compare
tanjunchen
commented
Jul 30, 2023
| # Consul2Istio | ||
|
|
||
| [](https://github.com/aeraki-framework/consul2istio/actions?query=branch%3Amaster+event%3Apush+workflow%3A%22ci%22) | ||
|
|
zhaohuabing
reviewed
Jul 30, 2023
Makefile
Outdated
| @@ -9,22 +9,23 @@ GOBIN?=$(GOPATH)/bin | |||
| # Build parameters | |||
| OUT?=./out | |||
| DOCKER_TMP?=$(OUT)/docker_temp/ | |||
| DOCKER_TAG?=aeraki/consul2istio:latest | |||
| DOCKER_TAG?=docker.io/tanjunchen/consul2istio:latest | |||
There was a problem hiding this comment.
Where should I push the image? ghcr.io/aeraki-mesh？
There was a problem hiding this comment.
Yes, we use github packages for releasing aeraki mesh images.
Makefile
Outdated
| BINARY_NAME?=$(OUT)/consul2istio | ||
| BINARY_NAME_DARWIN?=$(BINARY_NAME)-darwin | ||
| MAIN_PATH_CONSUL_MCP=./cmd/consul2istio/main.go | ||
|
|
||
| build: | ||
| CGO_ENABLED=0 GOOS=linux $(GOBUILD) -o $(BINARY_NAME) $(MAIN_PATH_CONSUL_MCP) | ||
| CGO_ENABLED=0 GOARCH=amd64 GOOS=linux $(GOBUILD) -o $(BINARY_NAME) $(MAIN_PATH_CONSUL_MCP) |
There was a problem hiding this comment.
the default goarch is supposed to be x86
There was a problem hiding this comment.
I make this parameter configurable.
Signed-off-by: chentanjun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@zhaohuabing