-
Notifications
You must be signed in to change notification settings - Fork 1.3k
fix: Assorted new docs fixes from testing #8875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
LFDanLu
wants to merge
16
commits into
main
Choose a base branch
from
docs_fixes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+120
−61
Open
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
c9aa612
fix modal so it always appears over mobile header and fix dropzone width
LFDanLu 0ecf094
add title font size resizing behavior to s2 docs
LFDanLu 96e5138
dont use useResizeObserver because we want to catch fonts changing
LFDanLu 8827283
fix mobile header icon and library label
LFDanLu ebc6a23
fix cross page anchor navigation scrolling and mobile cross page navi…
LFDanLu 36b0463
properly close mobile header menu when clicking on component card
LFDanLu 52f64c5
making image coordinator example wrap to new row instead of squishing…
LFDanLu c7c7a30
set a minwidth large enough so disallowEmptySelection have its label …
LFDanLu 987cff4
properly reobserve the new page post-navigation so the page nav picke…
LFDanLu 48b0cd1
remove broken title resizer code and fix rebase
LFDanLu 74ef767
restore styles
LFDanLu e3bfb1c
Merge branch 'main' of github.com:adobe/react-spectrum into docs_fixes
LFDanLu 451ac67
fix internationalized logo
LFDanLu 1d5918e
add 404 page
LFDanLu ed3fdf5
Merge branch 'main' of github.com:adobe/react-spectrum into docs_fixes
LFDanLu 018be32
forgot to remove test code
LFDanLu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
import Error from '../src/Error'; | ||
import {Layout} from '../src/Layout'; | ||
export default Layout; | ||
|
||
import docs from 'docs:@react-spectrum/s2'; | ||
|
||
<Error /> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
'use client'; | ||
|
||
// eslint-disable-next-line monorepo/no-internal-import | ||
import BrowserError from '@react-spectrum/s2/illustrations/linear/BrowserError'; | ||
import {Content, Heading, IllustratedMessage} from '@react-spectrum/s2'; | ||
|
||
export default function Error() { | ||
return ( | ||
<div style={{display: 'flex', alignItems: 'center', height: '50vh', justifyContent: 'center', flexDirection: 'row'}}> | ||
<IllustratedMessage> | ||
<BrowserError /> | ||
<Heading>Error 404: Page not found</Heading> | ||
<Content>This page isn't available. Try checking the URL or visit a different page.</Content> | ||
</IllustratedMessage> | ||
</div> | ||
); | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will probably conflict with #8964, but feel free to keep this version.