fix: Assorted new docs fixes from testing #8875
Open
+57
−43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
snowystinger
previously approved these changes
Sep 22, 2025
|
|
||
| // TODO: this causes a flash when the headings change size, maybe we just move this code | ||
| // to client and append suppressHydrationWarning to the h1s | ||
| export function TitleResizer() { |
There was a problem hiding this comment.
Want to use https://una.im/5-css-functions/#fluid-type if it's supported in the browser?
it's already in chrome Fyrd/caniuse#7368
|
Build successful! 🎉 |
…gation scroll positioning
… the images at small screen sizes
…r updates during scroll on mobile this is because the page doesnt actually remount, we reuse the existing component tree
LFDanLu
changed the title
|
Build successful! 🎉 |
reidbarber
reviewed
Sep 29, 2025
Comment on lines
99
to
120
| <div | ||
| className={style({ | ||
| isolation: 'isolate', | ||
| display: 'flex', | ||
| flexDirection: 'column', | ||
| alignItems: 'center', | ||
| maxWidth: { | ||
| default: 'full', | ||
| lg: 1280 | ||
| }, | ||
| marginX: 'auto', | ||
| marginY: 0, | ||
| padding: { | ||
| default: 0, | ||
| lg: 12 | ||
| }, | ||
| paddingBottom: 0, | ||
| gap: { | ||
| default: 0, | ||
| lg: 12 | ||
| } | ||
| })}> |
There was a problem hiding this comment.
Were these styles intentionally removed? It seems like the content takes up the full viewport width now.
There was a problem hiding this comment.
oh whoops, must of messed the rebase for this one, thanks for catching
|
Build successful! 🎉 |
snowystinger
approved these changes
Sep 29, 2025
yihuiliao
approved these changes
Sep 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: