Skip to content

fix(csharp): use Int8Type for BUFFER_LENGTH in column metadata schema #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
msrathore-db wants to merge 1 commit into from
Closed

fix(csharp): use Int8Type for BUFFER_LENGTH in column metadata schema #24

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion csharp/src/Hive2/MetadataSchemaDefinitions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ internal static Schema CreateColumnMetadataSchema()
new Field("DATA_TYPE", Int32Type.Default, true),
new Field("TYPE_NAME", StringType.Default, true),
new Field("COLUMN_SIZE", Int32Type.Default, true),
new Field("BUFFER_LENGTH", Int32Type.Default, true),

@eric-wang-1990 eric-wang-1990 Mar 6, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope Int8 is just up to 128, which is way to small for buffer length, we should use int32.

new Field("BUFFER_LENGTH", Int8Type.Default, true),
new Field("DECIMAL_DIGITS", Int32Type.Default, true),
new Field("NUM_PREC_RADIX", Int32Type.Default, true),
new Field("NULLABLE", Int32Type.Default, true),
Expand Down
Loading