fix(csharp): use Int8Type for BUFFER_LENGTH in column metadata schema#24
Closed
msrathore-db wants to merge 1 commit into
Closed
fix(csharp): use Int8Type for BUFFER_LENGTH in column metadata schema#24msrathore-db wants to merge 1 commit into
msrathore-db wants to merge 1 commit into
Conversation
The Databricks Thrift server returns BUFFER_LENGTH as Int8Type. The schema factory was incorrectly using Int32Type, causing type mismatches between Thrift and SEA metadata results. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
msrathore-db
added a commit
to adbc-drivers/databricks
that referenced
this pull request
Mar 6, 2026
Points to adbc-drivers/hiveserver2#24 which changes BUFFER_LENGTH from Int32Type to Int8Type in MetadataSchemaFactory to match the Thrift server's actual return type. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
| new Field("DATA_TYPE", Int32Type.Default, true), | ||
| new Field("TYPE_NAME", StringType.Default, true), | ||
| new Field("COLUMN_SIZE", Int32Type.Default, true), | ||
| new Field("BUFFER_LENGTH", Int32Type.Default, true), |
Contributor
There was a problem hiding this comment.
Nope Int8 is just up to 128, which is way to small for buffer length, we should use int32.
msrathore-db
added a commit
to adbc-drivers/databricks
that referenced
this pull request
Mar 9, 2026
…builder Revert hiveserver2 submodule to e42efb4 (MetadataSchemaFactory keeps BUFFER_LENGTH as Int32Type per JDBC spec). Revert FlatColumnsResultBuilder to Int32Array.Builder to match the schema. The Thrift server returns Int8 for BUFFER_LENGTH and the Thrift builder (DatabricksStatement line 830) uses Int8Array.Builder — those are unchanged. Tests assert Int8Type which matches the CreateExtendedColumnsResult code path. The schema factory fix (Int32→Int8) will be handled separately via adbc-drivers/hiveserver2#24 if needed. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Collaborator
|
@msrathore-db, I'm going to close this PR. Feel free to re-open if you think this is in error. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's Changed
The Databricks Thrift server returns BUFFER_LENGTH as Int8Type. The schema factory was incorrectly using Int32Type, causing type mismatches between Thrift and SEA metadata results.
Please fill in a description of the changes here.
This contains breaking changes.
Closes #NNN.