Skip to content

fix(release-rust): install zip for Windows-msvc packaging + cap build timeout #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
emmanuelm41 merged 1 commit into from
Jun 3, 2026
Merged

fix(release-rust): install zip for Windows-msvc packaging + cap build timeout #95

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions .github/workflows/_release-rust.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,9 @@ jobs:
name: Build ${{ matrix.target }}
needs: setup
runs-on: ${{ matrix.runner }}
# Cap a single target's build so a hang (e.g. a stalled cargo-xwin CRT/SDK
# download) fails fast instead of running to GitHub's 6h default.
timeout-minutes: 45
strategy:
fail-fast: false
matrix: ${{ fromJSON(needs.setup.outputs.matrix) }}
Expand Down Expand Up @@ -192,13 +195,15 @@ jobs:
# lld-link against the MSVC CRT + Windows SDK that `xwin` downloads, using
# clang/clang-cl as the C/C++ compiler. nasm + cmake are needed by native
# deps (aws-lc-sys, ring) whose build scripts assemble/cmake C for the
# target. Runs on the Linux build host (only reached when use_xwin=true).
# target. `zip` is needed by the Package step (Windows artifacts are .zip,
# and the Linux host has no `zip` by default). Runs on the Linux build host
# (only reached when use_xwin=true).
- name: Install xwin toolchain (Windows-msvc cross)
if: matrix.use_xwin
run: |
sudo apt-get update
sudo apt-get install -y --no-install-recommends \
clang lld llvm nasm cmake
clang lld llvm nasm cmake zip
- name: Install cargo-xwin
if: matrix.use_xwin
uses: taiki-e/install-action@v2
Expand Down