fix(release-rust): install zip for Windows-msvc packaging + cap build timeout - #95
Merged
Merged
Conversation
… timeout The cargo-xwin build of `-pc-windows-msvc` succeeds on Linux, but the Package step then fails with `zip: command not found` — Windows artifacts are zipped and the Linux build host has no `zip` by default. Add `zip` to the xwin toolchain install step. Also add `timeout-minutes: 45` to the build job so a stalled cargo-xwin CRT/SDK download fails fast instead of running to GitHub's 6h default. (Observed ~16min CRT downloads on some self-hosted runners with slow egress to Microsoft's CDN.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #94. First real release run (
kache v0.5.0-rc.2) revealed two issues with the cargo-xwin Windows path on self-hosted Linux runners:zip: command not foundin the Package step. Thecargo-xwinbuild of-pc-windows-msvcsucceeds (CRT/SDK download,aws-lc-syscompile, link, strip all pass), but Windows artifacts are.zipand the Linux host has nozip. → addzipto the xwin toolchain install step.timeout-minutes: 45so a stalled CRT/SDK download fails fast instead of burning toward GitHub's 6h cap. (Observed ~16 min CRT downloads onkunobi-runners— slow egress to Microsoft's CDN; not fatal, but worth bounding.)The build itself is proven working on
kunobi-runners— only packaging failed.Retag
v9to this commit after merge (kache pins@v9).