Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default behaviour is to name all files as
<basename>.jpg
on the assumption that all images are downloaded with typeimage/jpeg
. But this is not necessarily true, images may also be downloaded asimage/png
in which case the file-name is wrong.To fix this, add a new choice
native
to the option--images-format
and have it detect the actual downloaded image type from theContent-Type
header. Make this new choice the (changed) default choice. Keep the choicesjpg
andpng
but enforce conversion in both cases if the downloaded image does not match the desired format.