Minimize actions during re-downloads #43
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default behaviour is to name all files as `<basename>.jpg` on the assumption that all images are downloaded with type `image/jpeg`. But this is not necessarily true, images may also be downloaded as `image/png` in which case the file-name is wrong. To fix this, add a new choice `native` to the option `--images-format` and have it detect the actual downloaded image type from the `Content-Type` header. Make this new choice the (changed) default choice. Keep the choices `jpg` and `png` but enforce conversion in both cases if the downloaded image does not match the desired format.
When calling for a download again with a `dest`-directory filled by a previous download, minimize the number of network requests made: * don't redownload already present images * don't redownload already present chapter pages: this uses a heuristic that detects the presence of a chapter `<N>` by the presence of an image called `<N>_0*.<format>`, i.e. a partial chapter download will not be retried if any such image is present. Not affected are the downloads of the series description and of the chapter page used to get the information about the chapters: those still happen every time because the heuristic to skip those would be too fragile.
olaf-mandel
force-pushed
the
feature/minimize-redownloads
branch
from
5d5efaf to
4e9ec8d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calling for a download again with a
dest-directory filled by a previous download, minimize the number of network requests made:<N>by the presence of an image called<N>_0*.<format>, i.e. a partial chapter download will not be retried if any such image is present.Not affected are the downloads of the series description and of the chapter page used to get the information about the chapters: those still happen every time because the heuristic to skip those would be too fragile.
Related to #39: skips re-downloads, but without a new command-line flag
--skip-existing-chaptersDepends on #42