Open
Conversation
…o type pages, add defensive type effectiveness to pokemon pages
Zarel
changed the title
Owner
|
Hey, I actually like this design a lot, except it takes up quite a lot of space. When I have time I'll probably make a button to open it, and have it hidden by default. Or you could do that! Either way, thanks for the contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
I will say that I don't very much like the use of
PokedexTypePanel.prototypehere:https://github.com/phantamanta44/Pokemon-Showdown-Dex/blob/52dfeb284c849df399b4871de85e552401c6e713/js/pokedex-pokemon.js#L80
However, I couldn't find any existing cases of rendering code shared between different panel types (aside from external rendering functions from the Showdown libs), so I wasn't sure how I should structure it.
Closes #10