Open
Conversation
…o type pages, add defensive type effectiveness to pokemon pages
- Add note for ability-modified effectiveness (pokemon pages) - Deduplicate entries in immunity list (pokemon pages)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey @phantamanta44 and @Zarel I really like the addition in #33! Unfortunately I cannot push to that branch directly, so I added a commit here to implement Zarel's suggestion to make the display of the effectiveness section togglable, making it hidden by default.
Moreover, I added a couple more things:
Thanks everyone for the consideration - I hope we can get this landed, looks like a very nice and useful improvement!
Closes #10