Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create .coderabbit.yaml #62

Closed
wants to merge 2 commits into from
Closed

Create .coderabbit.yaml #62

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
161e72d
Create .coderabbit.yaml
Yashsharma1911 Nov 11, 2023
dac07a6
wrong changes made for testing
Yashsharma1911 Nov 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions .coderabbit.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
language: "en"
early_access: false
reviews:
high_level_summary: true
poem: true
review_status: true
collapse_walkthrough: false
path_filters:
- "!**/.xml"
path_instructions:
- path: "**.go"
instructions: "Review the Go code for conformity with the Go programming style guide, highlighting any deviations."
- path: "tests/**.*"
instructions: |
"Assess the unit test code employing the Mocha testing framework. Confirm that:
- The tests adhere to Mocha's established best practices.
- Test descriptions are sufficiently detailed to clarify the purpose of each test."
auto_review:
enabled: true
ignore_title_keywords:
- "WIP"
- "DO NOT MERGE"
drafts: false
base_branches:
- "develop"
- "feat/*"
chat:
auto_reply: false
4 changes: 4 additions & 0 deletions Maps/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,4 +25,8 @@ func main() {
for _, value := range languages {
fmt.Printf("for key value is %v\n", value)
}

for _ value := range languages {
fmt.Printf("for key value is %v\n", value)
}
Comment on lines +29 to +31
Copy link

@coderabbitai coderabbitai bot Nov 11, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a syntax error in the for loop. The underscore and value should be separated by a comma.

- for _ value := range languages {
+ for _, value := range languages {
Commitable suggestion

[!IMPORTANT]
Carefully review the code before committing. Make sure it correctly replaces the highlighted code, has no missing lines and indentaion issues.

Suggested change
for _ value := range languages {
fmt.Printf("for key value is %v\n", value)
}
for _, value := range languages {
fmt.Printf("for key value is %v\n", value)
}

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@coderabbitai I don't know how to make changes can you suggest a solution?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Yashsharma1911 Sure, I'd be happy to guide you through the process of making changes to your code. Here are the steps:

  1. Open the Maps/main.go file in your code editor.
  2. Locate the following lines of code:
for _ value := range languages {
    fmt.Printf("for key value is %v\n", value)
}
  1. Modify these lines to look like this:
for _, value := range languages {
    fmt.Printf("for key value is %v\n", value)
}
  1. Save the changes to the Maps/main.go file.
  2. Commit these changes with a descriptive message, for example: "Fixed syntax error in for loop".
  3. Push the changes to your branch.

This will update the pull request with your new changes. The underscore and value in the for loop should be separated by a comma. This is because in Go, the range keyword returns two values: the index and the value of the element at that index. If you don't need the index, you can ignore it with an underscore (_), but you still need to include the comma.

Let me know if you need further assistance!

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohh thankyou

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@coderabbitai I closed this PR

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Yashsharma1911 Understood, if you've closed the PR and do not need to make further changes, that's completely fine. If you decide to revisit the changes or need help with anything else in the future, feel free to reach out. Have a great day!

}