Skip to content

Fix: Install screens: “Log In” and "Support link" use old color #11373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hbhalodia wants to merge 3 commits into
base: trunk
Choose a base branch
from
+6 −6
Open

Fix: Install screens: “Log In” and "Support link" use old color #11373

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
85edd20
Fix link color to use new admin color on install and setup pages
hbhalodia Mar 27, 2026
b504160
Update the focus color to use same as active and hover
hbhalodia Mar 28, 2026
f4a2392
Update variable to use the name
hbhalodia Mar 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/wp-admin/css/install.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,16 +16,16 @@ body {
}

a {
color: #2271b1;
color: var(--wp-admin-theme-color);
}

a:hover,
a:active {
color: #135e96;
color: var(--wp-admin-theme-color-darker-20);
}

a:focus {
Copy link
Copy Markdown
Contributor

@audrasjb audrasjb Mar 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should also update the :focus color accordingly.

Copy link
Copy Markdown
Author

@hbhalodia hbhalodia Mar 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @audrasjb, I have updated to use same color as active and hover.

color: #043959;
color: var(--wp-admin-theme-color-darker-20);
border-radius: 2px;
box-shadow: 0 0 0 var(--wp-admin-border-width-focus, 1.5px) var(--wp-admin-theme-color, #3858e9);
/* Only visible in Windows High Contrast mode */
Expand Down
6 changes: 3 additions & 3 deletions src/wp-includes/functions.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3974,14 +3974,14 @@ function _default_wp_die_handler( $message, $title = '', $args = array() ) {
font-size: 14px ;
}
a {
color: #2271b1;
color: #2145e6;
Copy link
Copy Markdown
Contributor

@t-hamano t-hamano Mar 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are the reasons for using hardcoded values instead of CSS custom properties?

Copy link
Copy Markdown
Author

@hbhalodia hbhalodia Mar 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@t-hamano, This is executed before any of the variables are avialable in the context. Hence adding variable does not works because that variable is not present. Hence added the hardcoded value.

Copy link
Copy Markdown
Contributor

@t-hamano t-hamano Mar 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, thanks!

Copy link
Copy Markdown
Contributor

@t-hamano t-hamano Mar 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the default link color should be #3858e9, no? That is, the value that --wp-admin-theme-color points to when the modern color theme is enabled.

Copy link
Copy Markdown
Member

@shail-mehta shail-mehta Mar 28, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, the #3858e9 color aligns with the modern theme.

}
a:hover,
a:active {
color: #135e96;
color: #183ad6;
}
a:focus {
Copy link
Copy Markdown
Contributor

@audrasjb audrasjb Mar 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should also update the :focus color

Copy link
Copy Markdown
Author

@hbhalodia hbhalodia Mar 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @audrasjb, I have updated to use same color as active and hover.

color: #043959;
color: #183ad6;
box-shadow: 0 0 0 var(--wp-admin-border-width-focus, 1.5px) var(--wp-admin-theme-color, #3858e9);
outline: 2px solid transparent;
}
Expand Down
Loading