Skip to content

Fix: Install screens: “Log In” and "Support link" use old color#11373

Open
hbhalodia wants to merge 3 commits intoWordPress:trunkfrom
hbhalodia:fix/issue-64962
Open

Fix: Install screens: “Log In” and "Support link" use old color#11373
hbhalodia wants to merge 3 commits intoWordPress:trunkfrom
hbhalodia:fix/issue-64962

Conversation

@hbhalodia
Copy link
Copy Markdown

Trac ticket: https://core.trac.wordpress.org/ticket/64962

Description

  • Add CSS variable for install.css changes.
  • Add color hex code for wp_die functions.php code, as the variable was not added before that it executed wp_die.
  • Also added fix for setup-config.php if config already exists and related anchors. See before and after Screenshots.
Before After
Screenshot 2026-03-27 at 12 20 45 PM Screenshot 2026-03-27 at 12 16 28 PM

Use of AI Tools

  • None

This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 27, 2026

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props hbhalodia, huzaifaalmesbah, audrasjb, wildworks.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Copy link
Copy Markdown
Member

@huzaifaalmesbah huzaifaalmesbah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should use var(--wp-admin-theme-color, #3858e9) for the anchor color instead of var(--wp-admin-theme-color-darker-10). For hover and focus states, we can use var(--wp-admin-theme-color-darker-20, #183ad6).

@audrasjb
Copy link
Copy Markdown
Contributor

Before:
Capture d’écran 2026-03-28 à 06 02 19

After:
Capture d’écran 2026-03-28 à 06 03 02

@audrasjb
Copy link
Copy Markdown
Contributor

Thanks for the PR, this looks good to me 👍

Copy link
Copy Markdown
Contributor

@audrasjb audrasjb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing my approval as we also need to update the :focus colors

color: var(--wp-admin-theme-color-darker-20);
}

a:focus {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should also update the :focus color accordingly.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @audrasjb, I have updated to use same color as active and hover.

color: #135e96;
color: #183ad6;
}
a:focus {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should also update the :focus color

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @audrasjb, I have updated to use same color as active and hover.

}
a {
color: #2271b1;
color: #2145e6;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are the reasons for using hardcoded values instead of CSS custom properties?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@t-hamano, This is executed before any of the variables are avialable in the context. Hence adding variable does not works because that variable is not present. Hence added the hardcoded value.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, thanks!

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the default link color should be #3858e9, no? That is, the value that --wp-admin-theme-color points to when the modern color theme is enabled.

Copy link
Copy Markdown
Member

@shail-mehta shail-mehta Mar 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, the #3858e9 color aligns with the modern theme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants