Fix: Install screens: “Log In” and "Support link" use old color#11373
Fix: Install screens: “Log In” and "Support link" use old color#11373hbhalodia wants to merge 3 commits intoWordPress:trunkfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
huzaifaalmesbah
left a comment
There was a problem hiding this comment.
I think we should use var(--wp-admin-theme-color, #3858e9) for the anchor color instead of var(--wp-admin-theme-color-darker-10). For hover and focus states, we can use var(--wp-admin-theme-color-darker-20, #183ad6).
|
Thanks for the PR, this looks good to me 👍 |
audrasjb
left a comment
There was a problem hiding this comment.
Removing my approval as we also need to update the :focus colors
| color: var(--wp-admin-theme-color-darker-20); | ||
| } | ||
|
|
||
| a:focus { |
There was a problem hiding this comment.
I think we should also update the :focus color accordingly.
There was a problem hiding this comment.
Thanks @audrasjb, I have updated to use same color as active and hover.
| color: #135e96; | ||
| color: #183ad6; | ||
| } | ||
| a:focus { |
There was a problem hiding this comment.
we should also update the :focus color
There was a problem hiding this comment.
Thanks @audrasjb, I have updated to use same color as active and hover.
| } | ||
| a { | ||
| color: #2271b1; | ||
| color: #2145e6; |
There was a problem hiding this comment.
What are the reasons for using hardcoded values instead of CSS custom properties?
There was a problem hiding this comment.
@t-hamano, This is executed before any of the variables are avialable in the context. Hence adding variable does not works because that variable is not present. Hence added the hardcoded value.
There was a problem hiding this comment.
I think the default link color should be #3858e9, no? That is, the value that --wp-admin-theme-color points to when the modern color theme is enabled.
There was a problem hiding this comment.
Agreed, the #3858e9 color aligns with the modern theme.


Trac ticket: https://core.trac.wordpress.org/ticket/64962
Description
wp_diefunctions.php code, as the variable was not added before that it executed wp_die.setup-config.phpif config already exists and related anchors. See before and after Screenshots.Use of AI Tools
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.