Skip to content

Base Styles: Remove $palette-max-height variable #76633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
senadir wants to merge 1 commit into from
+2 −3
Closed

Base Styles: Remove $palette-max-height variable #76633

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/base-styles/_variables.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,6 @@ $admin-sidebar-width-big: 190px;
$admin-sidebar-width-collapsed: 36px;
$spinner-size: 16px;
$canvas-padding: $grid-unit-20;
$palette-max-height: 368px;

// Deprecated, please use --wpds-dimension-surface-width-* design tokens instead.
$modal-min-width: 320px;
Expand Down
2 changes: 1 addition & 1 deletion packages/commands/src/components/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@
}

[cmdk-root] > [cmdk-list] {
max-height: $palette-max-height; // Specific to not have commands overflow oddly.
max-height: 368px; // Specific to not have commands overflow oddly.
overflow: auto;
scroll-padding-top: $grid-unit-10;
scroll-padding-bottom: $grid-unit-10;
Expand Down
2 changes: 1 addition & 1 deletion packages/workflow/src/components/workflow-menu.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@
}

[cmdk-root] > [cmdk-list] {
max-height: $palette-max-height; // Specific to not have workflows overflow oddly.
max-height: 368px; // Specific to not have workflows overflow oddly.
overflow: auto;

// Ensures there is always padding bottom on the last group, when there are workflows.
Expand Down
Loading