Base Styles: Remove $palette-max-height variable#76633
Closed
Conversation
This variable was added in #72703 and is not part of the public API. Inline the value at usage sites to avoid exposing it via _variables.scss. This needs to be backported to wp/7.0 before the official release. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
github-actions
bot
added
[Package] Base styles
senadir
added
Backport to WP 7.0 Beta/RC
|
Size Change: 0 B Total Size: 8.75 MB ℹ️ View Unchanged
|
|
Flaky tests detected in d64071b. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/23248594804
|
youknowriad
approved these changes
Mar 19, 2026
Contributor
youknowriad
left a comment
youknowriad
left a comment
There was a problem hiding this comment.
Sass variables are not public APIs really, so it's ok to have them but I don't mind this PR either.
Contributor
Author
|
There was a comment that I can't find now about this, in this case, I will close this and it will land with the other PR |
senadir
removed
the
Backport to WP 7.0 Beta/RC
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
$palette-max-heightSCSS variable frompackages/base-styles/_variables.scssas it was never intended to be part of the public API368pxvalue at the two usage sites (commands and workflow palettes)Context
_variables.scssis effectively a public API surface (flagged in #75691). This variable should be removed before WordPress 7.0 ships to avoid it becoming a public commitment.Backport needed: This should be backported to
wp/7.0before the official release (April 9, 2026).Test plan
$palette-max-heightexist