Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme fix #45

Closed
wants to merge 4 commits into from
Closed

Theme fix #45

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2f28202
font-colorScheme-fixed-#44
Aryanryn09 Apr 30, 2023
359e4dd
colorScheme-nav-#44
Aryanryn09 Apr 30, 2023
60ae001
fixes
Aryanryn09 Apr 30, 2023
ceca367
Merge branch 'main' into theme-fix
Aryanryn09 May 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions docs/develop/wasmedge/features.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,11 +41,11 @@ Through the [WasmEdge-Quickjs](https://github.com/second-state/wasmedge-quickjs)

WasmEdge could be seamlessly integrated with the existing cloud-native infra.

To integrate WasmEdge with your existing cloud-native infrastructure, there are several options available for managing Wasm applications as "containers" under Kubernetes. These options enables you to run Linux containers and Wasm containers side by side within a Kubernetes cluster.
There are several options to manage Wasm apps as "containers" under Kubernetes. All options will give you a Kubernetes cluster that runs Linux containers and WasmWasm containers side by side.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
There are several options to manage Wasm apps as "containers" under Kubernetes. All options will give you a Kubernetes cluster that runs Linux containers and WasmWasm containers side by side.
There are several options to manage Wasm apps as "containers" under Kubernetes. All options will give you a Kubernetes cluster that runs Linux containers and Wasm containers side by side.


Option #1 is to [use an OCI runtime crun](../deploy/oci-runtime/crun) (the C version of runc — mainly supported by Red Hat). crun decides whether an OCI image is WasmWasm or Linux based on image annotations. If the image is annotated as wasm32, crun will bypass the Linux container setup and just use WasmEdge to run it. Based on crun, we can get the entire Kubernetes stack CRI-O, containerd, Podman, kind, micro k8s, and k8s to work with Wasm images.

Option #1 is to [use an OCI runtime crun](../deploy/oci-runtime/crun) (the C version of runc — mainly supported by Red Hat). crun decides whether an OCI image is Wasm or Linux based on image annotations. If the image is annotated as wasm32, crun will bypass the Linux container setup and just use WasmEdge to run it. If the image is annotated as wasm32, crun will bypass the Linux container setup and use WasmEdge to run the image. By using crun, you can get the entire Kubernetes stack - including CRI-O, containerd, Podman, kind, micro k8s, and k8s - to work with Wasm images.

Option #2 is to [use a containerd-shim to start Wasm "containers" via runwasi](../deploy/cri-runtime/containerd.md). Basically, containerd could look at the image's target platform. It uses runwasi if the image is wasm32 and runc if it is x86 / arm. This is the approach used by Docker + Wasm.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should keep Option #2.


## Cross Platform

Expand Down
100 changes: 27 additions & 73 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

34 changes: 20 additions & 14 deletions src/css/custom.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,25 +6,31 @@

/* You can override the default Infima variables here. */
:root {
--ifm-color-primary: #2e8555;
--ifm-color-primary-dark: #29784c;
--ifm-color-primary-darker: #277148;
--ifm-color-primary-darkest: #205d3b;
--ifm-color-primary-light: #33925d;
--ifm-color-primary-lighter: #359962;
--ifm-color-primary-lightest: #3cad6e;

--ifm-navbar-link-hover-color: #6495fd;
--ifm-footer-link-hover-color: #6495fd;
--ifm-menu-color-active: #20609f;
--ifm-link-color:#20609f;
--ifm-breadcrumb-color-active: #4973e8;
--ifm-color-primary: #c350ba;
--ifm-color-primary-dark: #c350ba;
--ifm-color-primary-darker: #c350ba;
--ifm-color-primary-darkest: #c350ba;
--ifm-color-primary-light: #c350ba;
--ifm-color-primary-lighter: #c350ba;
--ifm-color-primary-lightest: #c350ba;
--ifm-code-font-size: 95%;
--docusaurus-highlighted-code-line-bg: rgba(0, 0, 0, 0.1);
}

/* For readability concerns, you should choose a lighter palette in dark mode. */
[data-theme='dark'] {
--ifm-color-primary: #25c2a0;
--ifm-color-primary-dark: #21af90;
--ifm-color-primary-darker: #1fa588;
--ifm-color-primary-darkest: #1a8870;
--ifm-color-primary-light: #29d5b0;
--ifm-color-primary-lighter: #32d8b4;
--ifm-color-primary-lightest: #4fddbf;
--ifm-color-primary: #d693e1;
--ifm-color-primary-dark: #c97fd6;
--ifm-color-primary-darker: #b56bca;
--ifm-color-primary-darkest: #a357be;
--ifm-color-primary-light: #e1b6ec;
--ifm-color-primary-lighter: #e8c3f0;
--ifm-color-primary-lightest: #f2dfff;
Comment on lines +9 to +34
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes are also in another PR, #51 Can we remove those changes from this PR and focus on only one change i.e. to the features.md file?

--docusaurus-highlighted-code-line-bg: rgba(0, 0, 0, 0.3);
}