Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme fix #45

Closed
wants to merge 4 commits into from
Closed

Theme fix #45

wants to merge 4 commits into from

Conversation

Aryanryn09
Copy link
Contributor

Fonts and Color Sheme updated

This commit updates the color scheme and font used throughout the application. These changes should improve the overall visual design and usability of the application, while also making it more consistent with modern design trends wrt the theme of this website with the WasmEge website

Related issue

fixes #44

Screenshot 2023-04-30 102543

Signed-off-by: Aryan <[email protected]>
Signed-off-by: Aryan Bansod <[email protected]>
Signed-off-by: Aryan <[email protected]>
Signed-off-by: Aryan Bansod <[email protected]>
Signed-off-by: Aryan <[email protected]>
Signed-off-by: Aryan Bansod <[email protected]>
@Bhardwaj-Himanshu
Copy link

Hi @Aryanryn09,
Thank you so much for creating a pull request.
The changes are welcomed as well, but could you please also try attaching the screenshot of npm run build log with the pull request or build the project locally so that it does not throw a build error when merged as #46
Thanks!

@Aryanryn09
Copy link
Contributor Author

remote: Permission to WasmEdge/docs.git denied to Aryanryn09.
fatal: unable to access 'https://github.com/WasmEdge/docs.git/': The requested URL returned error: 403 i am getting this message what can i do to get myself unblocked

@Bhardwaj-Himanshu
Copy link

Could you elaborate a bit more about the error message and why are you getting it?

Inshort what are you trying to do?

@Aryanryn09
Copy link
Contributor Author

Could you elaborate a bit more about the error message and why are you getting it?

Inshort what are you trying to do?

i think i've made and deleted multiple pr's at the same time

@Bhardwaj-Himanshu
Copy link

Are you trying to push to the original Wasmedge repository or your forked repo?

You won't be having the permissions to push to the Wasmedge original docs repo.

@Aryanryn09 Aryanryn09 mentioned this pull request May 1, 2023
@alabulei1
Copy link
Collaborator

@Aryanryn09 LGTM! Could you fix the conflicts first? Sorry for my late reply. Because I was busy filling in more content to this doc.

@Aryanryn09
Copy link
Contributor Author

@Aryanryn09 LGTM! Could you fix the conflicts first? Sorry for my late reply. Because I was busy filling in more content to this doc.

Sure


Option #2 is to [use a containerd-shim to start Wasm "containers" via runwasi](../deploy/cri-runtime/containerd.md). Basically, containerd could look at the image's target platform. It uses runwasi if the image is wasm32 and runc if it is x86 / arm. This is the approach used by Docker + Wasm.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should keep Option #2.

@@ -41,11 +41,11 @@ Through the [WasmEdge-Quickjs](https://github.com/second-state/wasmedge-quickjs)

WasmEdge could be seamlessly integrated with the existing cloud-native infra.

To integrate WasmEdge with your existing cloud-native infrastructure, there are several options available for managing Wasm applications as "containers" under Kubernetes. These options enables you to run Linux containers and Wasm containers side by side within a Kubernetes cluster.
There are several options to manage Wasm apps as "containers" under Kubernetes. All options will give you a Kubernetes cluster that runs Linux containers and WasmWasm containers side by side.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
There are several options to manage Wasm apps as "containers" under Kubernetes. All options will give you a Kubernetes cluster that runs Linux containers and WasmWasm containers side by side.
There are several options to manage Wasm apps as "containers" under Kubernetes. All options will give you a Kubernetes cluster that runs Linux containers and Wasm containers side by side.

Comment on lines +9 to +34

--ifm-navbar-link-hover-color: #6495fd;
--ifm-footer-link-hover-color: #6495fd;
--ifm-menu-color-active: #20609f;
--ifm-link-color:#20609f;
--ifm-breadcrumb-color-active: #4973e8;
--ifm-color-primary: #c350ba;
--ifm-color-primary-dark: #c350ba;
--ifm-color-primary-darker: #c350ba;
--ifm-color-primary-darkest: #c350ba;
--ifm-color-primary-light: #c350ba;
--ifm-color-primary-lighter: #c350ba;
--ifm-color-primary-lightest: #c350ba;
--ifm-code-font-size: 95%;
--docusaurus-highlighted-code-line-bg: rgba(0, 0, 0, 0.1);
}

/* For readability concerns, you should choose a lighter palette in dark mode. */
[data-theme='dark'] {
--ifm-color-primary: #25c2a0;
--ifm-color-primary-dark: #21af90;
--ifm-color-primary-darker: #1fa588;
--ifm-color-primary-darkest: #1a8870;
--ifm-color-primary-light: #29d5b0;
--ifm-color-primary-lighter: #32d8b4;
--ifm-color-primary-lightest: #4fddbf;
--ifm-color-primary: #d693e1;
--ifm-color-primary-dark: #c97fd6;
--ifm-color-primary-darker: #b56bca;
--ifm-color-primary-darkest: #a357be;
--ifm-color-primary-light: #e1b6ec;
--ifm-color-primary-lighter: #e8c3f0;
--ifm-color-primary-lightest: #f2dfff;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes are also in another PR, #51 Can we remove those changes from this PR and focus on only one change i.e. to the features.md file?

@adithyaakrishna
Copy link
Contributor

@Aryanryn09 Could you please let us know if you have any updates on this PR?

@alabulei1
Copy link
Collaborator

Since @Aryanryn09 didn't update this PR, I will close this PR first.

If you're ready to update the PR, please reopen it. Thanks.

@alabulei1 alabulei1 closed this Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Align with the theme
4 participants