Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ControllerCommands for rumbling #69

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Noah-H3467
Copy link
Contributor

Also switch transition commands that aren't auto or mid-intaking to the rumble version

@skukshtel
Copy link
Contributor

@Noah-H3467 Let's reconsider how we are doing this.

  1. I would get rid of the ContollerCommands class and extend the CommandXboxController class to create a new class that includes the Rumble commands. Use that new class in RobotContainer to create the Driver controller instance. That way you have the commands you need in the same class - no need to use a separate class with static methods.
  2. Instead of creating new methods in Superstucture, just add the .andThen(...) clause to each of the commands in RobotContainer that needs it. Yes it's a little more code, but it keeps the rumble command decoration in the same class that manages all of the controller mapping and functionality. It keeps the Superstructure class clean and free of extraneous functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants