Static Characterization for Arm and Elevator #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CJendantix
reviewed
Feb 4, 2025
|
I made a command that changes the state because it accesses the io's runCurrent(), which is normally run in the Generic Motion Profiled subsystem's state machine switch statement (the drive subsystem does not use the Generic subsystem setup so that is why there is no need for a new state in drive.java) Creating a new state in the Elevator and Arm subsystems prevents the Generic from running an output from an other state (like trying to go to a certain position prescribed by the state) and also we can focus on the data logged by the Command, not too much extra stuff in Generic. |
CJendantix
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.