Revise Kraken config for 1.1 board #500
Open
+6
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change A/B sense_resistor value to 1.1 board spec.
Contributor
|
I don't think this P.R. will work in its current form. Simply changing the setting to be right for a different board revision doesn't really solve the problem, just moves the problem around. I think the correct approach is to set the field to something invalid (-1? not sure, haven't tested) to make klipper refuse to start, and then have a comment explaining what the valid options are. The other possibility would be to have to separate config files, but that seems a little drastic for the small number of changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are small but subtle changes between versions 1.0 and 1.1 of the BIGTREETECH Kraken 1.1 board. Of note, the
Rsensevalue has changed for stepper drivers on S1-S4. From the BTT Product Wiki:Accordingly, the values for
sense_resistor:should change from0.022to0.050. I hope updating this default saves others many hours of hair pulling and searching!