Primary Score Ranges #501
Closed
Primary Score Ranges #501
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…refactor activeRangeKey for readability and type consistency
jstone-dev
approved these changes
Oct 8, 2025
| return this.primaryScoreRange === this.scoreSet.scoreRanges?.investigatorProvided | ||
| }, | ||
| oddsPathSources() { | ||
| console.log(this.primaryScoreRange) |
There was a problem hiding this comment.
Suggested change
| console.log(this.primaryScoreRange) |
|
Closing in favor of #529. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UI Support for VariantEffect/mavedb-api#532
This pull request introduces improvements to how clinical performance and publication source information are displayed and handled in the assay fact sheet and related components. The main changes include more robust primary range selection, clearer UI indicators for non-investigator-provided data, and centralizing source-matching logic.
Clinical Performance & Range Handling:
zeibergCalibration,scottCalibration,fayerCalibration) inScoreSetRanges, and aprimaryflag to indicate the main range for display and logic purposes.AssayFactSheet.vueandScoreSetHistogram.vueto consistently select and display the primary score range, falling back toinvestigatorProvidedif necessary. [1] [2]UI/UX Improvements:
*and a detailed note with source links when OddsPath data comes from non-primary sources, improving transparency for users. See image below:Source Matching Refactor:
matchSourcesutility insrc/lib/score-sets.ts, ensuring consistent matching of publication identifiers across components.RangeTable.vueandAssayFactSheet.vueto use the newmatchSourcesfunction for both threshold and OddsPath sources, removing duplicate logic. [1] [2] [3]Type and Prop Improvements:
Histogram and Range Selection Logic:
ScoreSetHistogram.vueto better handle range selection and classification, including defaulting to the primary range and making range key logic more robust. [1] [2] [3] [4] [5]