Skip to content

translation: match how Wi-Fi is spelt in every language smartly#523

Merged
VREMSoftwareDevelopment merged 1 commit intoVREMSoftwareDevelopment:mainfrom
lucasmz-dev:wifi-spelling
May 25, 2025
Merged

translation: match how Wi-Fi is spelt in every language smartly#523
VREMSoftwareDevelopment merged 1 commit intoVREMSoftwareDevelopment:mainfrom
lucasmz-dev:wifi-spelling

Conversation

@lucasmz-dev
Copy link
Collaborator

Thanks for sending a pull request!

How to submit a pull request

What does this implement/fix? Please describe.
Wi-Fi is spelt as WiFi in the original en-US fastlane files, which does not match the app strings

Does this close any currently open issues?

  • Please provide issue(s) number.

Additional context

Being aware of #276 and matching how the contributors named Wi-Fi in their language (checking who modified which lines) also doing some basic checking on Wikipedia and their translated pages

Where has this been tested?

  • Operating System:
  • Platform:
  • Target Platform:
  • Toolchain Version:
  • SDK Version:

Almost all translation for fastlane were using "WiFi" despite their strings file using Wi-Fi. Including en-US.

That was replaced, ignoring WiFiAnalyzer, then looking at the translations for the app itself, when Wi-Fi was not spelt as not exactly "Wi-Fi" but something else, we applied that change globally for that language.

Being aware of VREMSoftwareDevelopment#276
@codecov
Copy link

codecov bot commented May 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.26%. Comparing base (26c34d4) to head (31aee6b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #523   +/-   ##
=========================================
  Coverage     95.26%   95.26%           
  Complexity      868      868           
=========================================
  Files           123      123           
  Lines          2618     2618           
  Branches        194      194           
=========================================
  Hits           2494     2494           
  Misses           44       44           
  Partials         80       80           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lucasmz-dev
Copy link
Collaborator Author

The only two languages that have full descriptions in Fastlane are en-US (which should be Wi-Fi) and Russian, which may have been modified in #499

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR standardizes the spelling of “Wi-Fi” (or local variant) across app store metadata and updates one in-app string to match.

  • Harmonize “Wi-Fi” vs “WiFi” in all fastlane metadata translations
  • Adjust Dutch in-app strings to use “Wifi” consistently

Reviewed Changes

Copilot reviewed 22 out of 22 changed files in this pull request and generated no comments.

File Description
fastlane/metadata/android/*/short_description.txt Updated “WiFi” to local “Wi-Fi” or “Wifi” as appropriate
fastlane/metadata/android/*/full_description.txt Same hyphenation updates in full descriptions
app/src/main/res/values-nl/strings.xml Changed in-app “Wi-Fi” label to “Wifi” in throttle messages
Comments suppressed due to low confidence (2)

app/src/main/res/values-nl/strings.xml:129

  • The string value includes extra double quotes; these will show up verbatim in the UI. Consider removing the surrounding quotes for a cleaner user-facing message.
<string name="wifi_throttling_on">"Wifi-scanbeperking is ingeschakeld"</string>

app/src/main/res/values-nl/strings.xml:130

  • The string value includes extra double quotes; these will show up verbatim in the UI. Consider removing the surrounding quotes for a cleaner user-facing message.
<string name="wifi_throttling_off">"Wifi-scanbeperking is uitgeschakeld"</string>

@VREMSoftwareDevelopment
Copy link
Owner

  • Wi-Fi is a registered trademark: The Wi-Fi Alliance, the organization that promotes and standardizes Wi-Fi technology, has a registered trademark on "Wi-Fi".
  • "Wifi" or ""WiFi" is widely used: Despite the trademark, the term "Wifi" or "WiFi" is frequently used in common language and in many styles guides.
  • "Wi-Fi" is the preferred spelling when referring to the technology itself: Use "Wi-Fi" when referring specifically to the Wi-Fi technology or the Wi-Fi Alliance standards

@VREMSoftwareDevelopment VREMSoftwareDevelopment merged commit e19de00 into VREMSoftwareDevelopment:main May 25, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants