translation: match how Wi-Fi is spelt in every language smartly#523
Merged
VREMSoftwareDevelopment merged 1 commit intoVREMSoftwareDevelopment:mainfrom May 25, 2025
Merged
Conversation
Almost all translation for fastlane were using "WiFi" despite their strings file using Wi-Fi. Including en-US. That was replaced, ignoring WiFiAnalyzer, then looking at the translations for the app itself, when Wi-Fi was not spelt as not exactly "Wi-Fi" but something else, we applied that change globally for that language. Being aware of VREMSoftwareDevelopment#276
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #523 +/- ##
=========================================
Coverage 95.26% 95.26%
Complexity 868 868
=========================================
Files 123 123
Lines 2618 2618
Branches 194 194
=========================================
Hits 2494 2494
Misses 44 44
Partials 80 80 🚀 New features to boost your workflow:
|
Collaborator
Author
|
The only two languages that have full descriptions in Fastlane are en-US (which should be Wi-Fi) and Russian, which may have been modified in #499 |
There was a problem hiding this comment.
Pull Request Overview
This PR standardizes the spelling of “Wi-Fi” (or local variant) across app store metadata and updates one in-app string to match.
- Harmonize “Wi-Fi” vs “WiFi” in all fastlane metadata translations
- Adjust Dutch in-app strings to use “Wifi” consistently
Reviewed Changes
Copilot reviewed 22 out of 22 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| fastlane/metadata/android/*/short_description.txt | Updated “WiFi” to local “Wi-Fi” or “Wifi” as appropriate |
| fastlane/metadata/android/*/full_description.txt | Same hyphenation updates in full descriptions |
| app/src/main/res/values-nl/strings.xml | Changed in-app “Wi-Fi” label to “Wifi” in throttle messages |
Comments suppressed due to low confidence (2)
app/src/main/res/values-nl/strings.xml:129
- The string value includes extra double quotes; these will show up verbatim in the UI. Consider removing the surrounding quotes for a cleaner user-facing message.
<string name="wifi_throttling_on">"Wifi-scanbeperking is ingeschakeld"</string>
app/src/main/res/values-nl/strings.xml:130
- The string value includes extra double quotes; these will show up verbatim in the UI. Consider removing the surrounding quotes for a cleaner user-facing message.
<string name="wifi_throttling_off">"Wifi-scanbeperking is uitgeschakeld"</string>
Owner
|
e19de00
into
VREMSoftwareDevelopment:main
5 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for sending a pull request!
How to submit a pull request
What does this implement/fix? Please describe.
Wi-Fi is spelt as WiFi in the original en-US fastlane files, which does not match the app strings
Does this close any currently open issues?
Additional context
Being aware of #276 and matching how the contributors named Wi-Fi in their language (checking who modified which lines) also doing some basic checking on Wikipedia and their translated pages
Where has this been tested?