Skip to content

fix: ensure lifecycle observer added on main thread #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: ensure lifecycle observer added on main thread #145

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions unleashandroidsdk/src/main/java/io/getunleash/android/DefaultUnleash.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,8 @@ import kotlinx.coroutines.runBlocking
import kotlinx.coroutines.withContext
import kotlinx.coroutines.withTimeout
import java.io.File
import java.util.concurrent.CopyOnWriteArrayList
import java.util.concurrent.ConcurrentHashMap
import java.util.concurrent.CopyOnWriteArrayList
import java.util.concurrent.TimeoutException
import java.util.concurrent.atomic.AtomicBoolean

Expand Down Expand Up @@ -126,10 +126,10 @@ class DefaultUnleash(
)
else NoOpMetrics()
fetcher = UnleashFetcher(
unleashConfig,
httpClientBuilder.build("poller", unleashConfig.pollingStrategy),
unleashContextState.asStateFlow()
)
unleashConfig = unleashConfig,
httpClient = httpClientBuilder.build("poller", unleashConfig.pollingStrategy),
unleashContext = unleashContextState.asStateFlow()
)
taskManager = LifecycleAwareTaskManager(
dataJobs = buildDataJobs(metrics, fetcher),
networkAvailable = networkStatusHelper.isAvailable(),
Expand Down Expand Up @@ -168,7 +168,9 @@ class DefaultUnleash(
readyOnFeaturesReceived()
}
cache.subscribeTo(fetcher.getFeaturesReceivedFlow())
lifecycle.addObserver(taskManager)
coroutineScope.launch(Dispatchers.Main) {
lifecycle.addObserver(taskManager)
}
if (bootstrapFile != null && bootstrapFile.exists()) {
UnleashLogger.i(TAG, "Using provided bootstrap file")
Parser.proxyResponseAdapter.fromJson(bootstrapFile.readText())?.let { state ->
Expand Down
Loading