fix: ensure lifecycle observer added on main thread #145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unleash startup could crash if start was triggered on a background thread
Contributor
|
Hi @jasonctoms we're wondering if this could risk blocking the rendering thread. Maybe a test case would help to validate how it fails. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
Unleash startup could crash if
startwas triggered on a background thread. This change ensures that the lifecycle observer is always added on the main thread.Discussion points
If this change is not desirable, I think
startshould at least be marked with@MainThread. We discovered this issue when we were changing dependency injection frameworks where sometimes dependencies are created lazily on threads.