Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention the usage of Node's LTS version to avoid errors in React course #26385

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

ScaxCodes
Copy link
Contributor

@ScaxCodes ScaxCodes commented Sep 25, 2023

Because

If students are using the newest Node version 20.x, the commands in the lesson will throw an error. The usage of Node's LTS version prevents that, so we added a little reminder to this lesson.

This PR

  • mention the usage of the LTS version of Node in the lesson

Issue

Closes #26351

Additional Information

  • none

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project Contributing Guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

@github-actions github-actions bot added the Content: React Involves the React course label Sep 25, 2023
@ScaxCodes
Copy link
Contributor Author

Please let me know if this worked out, its my first PR.

@xandora
Copy link
Member

xandora commented Sep 25, 2023

I think you have this backwards. The bug is due to an interaction with LTS node and Vite. The fix is to install 20.x, not LTS.

Don't mind me. Just testing it out, our instructions work fine assuming users are indeed following our curriculum and installing/using LTS.

Copy link
Member

@xandora xandora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay to me.

@xandora xandora merged commit 1bb0784 into TheOdinProject:main Sep 26, 2023
@ScaxCodes
Copy link
Contributor Author

@xandora thank you michael, is it okay if i PR other "good first issues", or is it really only for the first one ever?
do you have any recommendations for my next PRs?

@ScaxCodes ScaxCodes deleted the feature/mention-LTS-version branch September 26, 2023 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content: React Involves the React course
Projects
None yet
Development

Successfully merging this pull request may close these issues.

React: Vite not running
2 participants