fix: use pkg-config to find ffmpeg libraries#573
Open
UlyssesZh wants to merge 1 commit intoTeamFlos:mainfrom
Open
fix: use pkg-config to find ffmpeg libraries#573UlyssesZh wants to merge 1 commit intoTeamFlos:mainfrom
UlyssesZh wants to merge 1 commit intoTeamFlos:mainfrom
Conversation
Author
|
For Windows, maybe we can use the vcpkg crate. I need some time to investigate it. |
Contributor
|
Related to patches from NixOS/nixpkgs#426525 (nixpkgs) |
Contributor
|
LGTM, @Mivik plz review? |
Contributor
|
but for windows build...? Why not keep those three methods ( |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this fix, there is no need to separately download statically linked libraries for building Phira. Tested building on Linux and macOS.