phira{,-unwrapped,-free}: init at 0.6.7 by UlyssesZh · Pull Request #426525 · NixOS/nixpkgs

UlyssesZh · 2025-07-18T23:49:46Z

I wrote a patch to make the game load assets from and download data to ~/.local/share/phira instead of the installation dir (among other patches to fix the build). Currently it seems to work without flaw on Linux.

The build on macOS cannot launch because the window creation with GL capabilities fails, but it can probably be due to I am testing in a VM (where I cannot seem to write some code myself to use GLFW to create a window, either). More testing is needed.

Things done

Add a 👍 reaction to pull requests you find important.

pkgs/by-name/ph/phira/package.nix

Bot-wxt1221

patch lgtm

pkgs/by-name/ph/phira/package.nix

pkgs/by-name/ph/phira/ffmpeg.patch

Bot-wxt1221

All thing worked!

Bot-wxt1221

Package work for me with x11

Bot-wxt1221 · 2025-07-19T08:10:07Z

Let's unfree.

TeamFlos/phira#578 (comment)

UlyssesZh · 2025-07-19T08:23:45Z

He didn't understand the question at first. He thought you were talking about some source codes.

UlyssesZh · 2025-07-19T08:30:55Z

I added unfree for now. Will remove if fine after further response from upstream.

Bot-wxt1221 · 2025-07-19T08:43:36Z

Could there be a bin package?

TeamFlos/phira#298

Maybe we can replace the missing file with nixos logos.

UlyssesZh · 2025-07-19T08:45:02Z

Unfortunately, their binary releases do not contain unfree features, either. Only the Android and iOS releases have unfree features.

Bot-wxt1221 · 2025-07-19T08:47:06Z

I suggest seperate the package and assests to prevent building on user's computer.

UlyssesZh · 2025-07-19T08:52:22Z

Maybe we can replace the missing file with nixos logos.

I suggest seperate the package and assests to prevent building on user's computer.

Yeah I think replacing unfree assets with free assets to make the package free is a good idea, but NixOS logos may not be suitable for a background. I will figure this out after the upstream developers respond to the question about assets copyright issues.

If the assets are unfree, I am thinking of having the package phira free, and it has an overridable parameter that specifies the assets. If unset, free substitute assets will be used. And then we can have another package phira-unfree, defined as phira.override { overrideAssets = somePackageContainingUnfreeAssets }.

The names of the two packages may alternatively be phira-free and phira respectively. I personally think either naming is okay.

pkgs/by-name/ph/phira/assets.patch

Aleksanaa · 2025-07-22T12:56:15Z

pkgs/by-name/ph/phira/package.nix

+      makeWrapper $out/bin/phira-main $out/bin/phira \
+        ${lib.optionalString stdenv.hostPlatform.isLinux "--suffix LD_LIBRARY_PATH : ${lib.makeLibraryPath [ libGL ]}"} \
+        --run '
+          export PHIRA_ROOT=''${PHIRA_ROOT-"$HOME/.local/share/phira"}


Don't think putting the logic here is a good one. And without it we can make use of makeBinaryWrapper which should be faster.

I don't want to maintain a patch with too much logic. The performance impact from makeWrapper is very minimal.

pkgs/by-name/ph/phira/package.nix

UlyssesZh · 2025-07-22T20:14:28Z

I separated it into two packages phira and phira-unwrapped. The unwrapped package does not have assets but is free. This will fix the binary cache problem.

Aleksanaa · 2025-07-24T15:02:29Z

What are phira-main, phira-monitor and prpr-pbc in $out/bin? Are they supposed to work? Currently they just exit with segfault.
It is copying the whole assets to ~/.local/share/phira on launch. Can we prevent that? Downloaded files should be in ~/.local/share/phira/data I guess.
Would be good to provide a desktop file and an icon.

UlyssesZh · 2025-07-24T17:42:35Z

What are phira-main, phira-monitor and prpr-pbc in $out/bin? Are they supposed to work? Currently they just exit with segfault.

phira-monitor needs to be wrapped with libGL and PHIRA_ROOT, and you also need to put a monitor-config.yml in PHIRA_ROOT with the fields email, password, server, roomId. Otherwise, it will just exist with segfault. It is used to see the current status of a multiplayer stage.

prpr-pbc is a command line tool to convert between different chart formats. It exits with segfaul if you do not provide any command line options.

phira-main is just unwrapped phira.

It is copying the whole assets to ~/.local/share/phira on launch. Can we prevent that? Downloaded files should be in ~/.local/share/phira/data I guess.

I would like to put assets and downloaded files in different locations, but then I need to do some large refactoring of the code base.

UlyssesZh · 2025-07-24T22:41:54Z

A desktop file is now added.

phira-main and phira-monitor are now wrapped so that one can run them directly.

I added the package phira-free, which has a pure-color image as background and a free font (Ubuntu regular). The font does not support CJK, so it is a bit bad.

Bot-wxt1221 · 2025-10-04T08:48:46Z

could you rebase and nixfmt？

UlyssesZh · 2025-10-04T08:51:12Z

Thank you for reminding. I will do that tomorrow.

SuperSandro2000 · 2025-11-06T16:01:00Z

pkgs/by-name/ph/phira-unwrapped/ffmpeg.patch

Would be nice to upstream this

See TeamFlos/phira#573. It currently cannot be merged upstream because it breaks build on Windows.

UlyssesZh force-pushed the phira branch from 41b27c9 to 5b6656e Compare July 19, 2025 01:28

nixpkgs-ci bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. labels Jul 19, 2025

UlyssesZh force-pushed the phira branch from 5b6656e to 0e4da91 Compare July 19, 2025 04:43

Bot-wxt1221 reviewed Jul 19, 2025

View reviewed changes

pkgs/by-name/ph/phira/package.nix Outdated Show resolved Hide resolved

nixpkgs-ci bot removed the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Jul 19, 2025