Repository navigation
Retire services_yaml_profile/_audit, read registration from the container - #16
Merged
Merged
Conversation
2 tasks done
mpysiak
force-pushed
the
retire-services-yaml-tools
branch
from
September 28, 2026 04:39
4208060 to
f4e703f
Compare
… lookups Both tools parsed services YAML and broke on custom tags. How a class ended up registered is now read from the compiled container through the Symfony bridge: symfony-service-detail reports the autowired/autoconfigured flags since 0.14, and classes swallowed by a glob exclude show up under the container.excluded tag. bin/console debug:container stays as the fallback without the bridge. Skills follow the 0.14 service-detail shape (arguments, not constructor) and no longer force --format=json where the output is only read.
GSadee
force-pushed
the
retire-services-yaml-tools
branch
from
September 28, 2026 05:19
f4e703f to
244454f
Compare
GSadee
approved these changes
Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #15.
Summary
sylius_services_yaml_profileandsylius_services_yaml_audit(tools, wiring, tests). They parsed services YAML and failed on custom tags; the container is the source of truth for how a class ended up registered.sylius_services_yaml_patch_excludestays — it edits the file.INSTRUCTIONS.md, README and the skills now point to the Symfony bridge for registration checks:symfony-service-detail --id=<FQCN>—autowired/autoconfigured/publicflags (new in 0.14) and resolvedarguments,symfony-services --tag=container.excluded --query=<FQCN>— the class was swallowed by a globexclude:,bin/console debug:container <id> --show-arguments(same flags).sylius_project_profile(it already reports theexclude:entries and the bridge presence).symfony-service-detailoutput shape: constructor wiring is underarguments, notconstructor.sylius-verify: dropped--format=jsononsymfony-service-detail— the output is only read, and since 0.14tools:callswitches to JSON by itself for large results.Test plan
vendor/bin/phpunit(unit + integration)vendor/bin/phpstan analyseabstractdefinitions taggedcontainer.excluded