Skip to content

Skills: constructor arguments from service-detail, dotenv-check before email capture - #17

Merged
GSadee merged 2 commits into
mainfrom
skills-constructor-args-dotenv
Sep 28, 2026
Merged

GSadee merged 2 commits into
mainfrom
skills-constructor-args-dotenv

Conversation

@mpysiak

@mpysiak mpysiak commented Sep 28, 2026

Copy link
Copy Markdown
Member

Stacked on #16.

Summary

  • sylius-resource: after sylius_resource_inspect, one symfony-service-detail lookup each confirms the compiled wiring:
    • app.repository.<alias> — repository class + entity manager + ClassMetadata for the entity,
    • app.factory.<alias> — with a custom factory the first arguments entry must be the entity FQCN as a scalar (string $className); a service reference means the factory was wired as a wrapper (R-NO-CUSTOM-FACTORY).
  • sylius-dev: next to sylius_service_decorators — symfony-service-detail --id=<original_service_id> shows what the outermost decorator receives as .inner.
  • sylius-verify: environment check before choosing the email proof — symfony-dotenv-check for MAILER_DSN, DATABASE_URL and the messenger DSNs (declared where, resolves or not), then sylius_email_capture_status, which stays mandatory because dotenv-check masks the value and cannot tell smtp:// from null://.
  • README lists symfony-dotenv-check among the bridge tools the skills use.

Fallback without the bridge stays bin/console debug:container <id> --show-arguments / grepping .env*.

Test plan

  • vendor/bin/phpunit --testsuite unit (skills structure test)
  • Checked the repository/factory argument shapes against the test application's dumped container

@mpysiak
mpysiak force-pushed the skills-constructor-args-dotenv branch from 9177021 to a4c8167 Compare September 28, 2026 04:39
@mpysiak
mpysiak added this pull request to stack #18 September 28, 2026 05:03
@GSadee
GSadee force-pushed the skills-constructor-args-dotenv branch from a4c8167 to 7a2ae05 Compare September 28, 2026 05:19
Base automatically changed from retire-services-yaml-tools to main September 28, 2026 05:20
sylius-resource confirms the compiled repository and factory wiring after
sylius_resource_inspect (a custom factory must receive the entity FQCN as a
scalar), sylius-dev reads what a decorator wraps as .inner from the outermost
decorator's arguments, and sylius-verify checks where MAILER_DSN, DATABASE_URL
and messenger DSNs are declared before sylius_email_capture_status.
@GSadee
GSadee force-pushed the skills-constructor-args-dotenv branch from 7a2ae05 to 612700f Compare September 28, 2026 05:20
@GSadee
GSadee merged commit 7c10992 into main Sep 28, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants