chore(web): cleanup stale code#2350
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Simplicity
Automated validation
Independent review
Test plan
Note
Medium Risk
Broad deletions touch provider wiring and shared types; risk is mainly if any removed module was still referenced outside the diff, though greps suggest dead code. No auth or payment logic changes beyond a toast string.
Overview
Removes a large slice of unused web code—legacy grid overlap layout,
EventInViewParser/ view-parser tests, grid event validator, DexiehandleDatabaseErrorplumbing, sharedapi.typespagination helpers, and several UI pieces (custom Phosphor icon wrappers,DropZone,ShortcutTip,LoginAbsoluteOverflowLoader,CompassRefsProvider/useCompassRefs).Test harness is slimmed:
renderHookWithStoreis dropped (docs now point atmock.render.tsxforrenderHook), plus deletedsetTestWindowUrland duplicatemockNavigatorPlatform(platform mocking stays inmock.setup.ts). Related unit tests for removed modules are deleted with the code.Types and exports are tightened—
Option_Time→TimeOption, date helpers colocateSelectedDates/ time-change params,DividerandTextareainline their props, and several ports/types stop being exported.user-metadata.storedrops unusedselectUserMetadata/selectGoogleMetadata.Sessionexposeslistenersas a public field instead of a private#listenersset.Provider tree no longer wraps the app in
CompassRefsProvider. Minor copy tweak on the sign-out error toast (emoji removed).Reviewed by Cursor Bugbot for commit 435ba76. Bugbot is set up for automated code reviews on this repo. Configure here.