Skip to content

chore(web): cleanup stale code#2350

Merged
tyler-dane merged 6 commits into
mainfrom
chore/cleanup-07-23
Jul 24, 2026
Merged

chore(web): cleanup stale code#2350
tyler-dane merged 6 commits into
mainfrom
chore/cleanup-07-23

Conversation

@tyler-dane

@tyler-dane tyler-dane commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Summary

Simplicity

Automated validation

Independent review

Test plan


Note

Medium Risk
Broad deletions touch provider wiring and shared types; risk is mainly if any removed module was still referenced outside the diff, though greps suggest dead code. No auth or payment logic changes beyond a toast string.

Overview
Removes a large slice of unused web code—legacy grid overlap layout, EventInViewParser / view-parser tests, grid event validator, Dexie handleDatabaseError plumbing, shared api.types pagination helpers, and several UI pieces (custom Phosphor icon wrappers, DropZone, ShortcutTip, LoginAbsoluteOverflowLoader, CompassRefsProvider / useCompassRefs).

Test harness is slimmed: renderHookWithStore is dropped (docs now point at mock.render.tsx for renderHook), plus deleted setTestWindowUrl and duplicate mockNavigatorPlatform (platform mocking stays in mock.setup.ts). Related unit tests for removed modules are deleted with the code.

Types and exports are tightened—Option_TimeTimeOption, date helpers colocate SelectedDates / time-change params, Divider and Textarea inline their props, and several ports/types stop being exported. user-metadata.store drops unused selectUserMetadata / selectGoogleMetadata. Session exposes listeners as a public field instead of a private #listeners set.

Provider tree no longer wraps the app in CompassRefsProvider. Minor copy tweak on the sign-out error toast (emoji removed).

Reviewed by Cursor Bugbot for commit 435ba76. Bugbot is set up for automated code reviews on this repo. Configure here.

@tyler-dane
tyler-dane merged commit b30b688 into main Jul 24, 2026
19 checks passed
@tyler-dane
tyler-dane deleted the chore/cleanup-07-23 branch July 24, 2026 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant