refactor(web): open week event form via draft store - #2351
Merged
Conversation
Drop the Week draft openForm action; callers and internal paths use draftActions.setFormOpen(true) directly since form-open is store-owned. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
openFormaction from the public DraftContext surface.useGridMouseUpandWeekInteractionCoordinatoropen the form withdraftActions.setFormOpen(true).setIsFormOpen(true)(already the store action).Simplicity
Net reduction: one fewer DraftContext action, no new hooks. Form-open was already store-owned; this deletes the redundant Week wrapper.
Manual Testing Steps
Test plan
bun test:web packages/web/src/views/Week/components/Draft/hooks/actions/useDraftActions.test.ts(9 pass)bun run type-check:web-tests+ web apptsc --noEmitbun lint(pre-existing unused-import warning in__tests__/render-with-store.tsxfrom chore(web): cleanup stale code #2350)Made with Cursor