Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2270: External DB Support #2457

Merged
merged 11 commits into from
Jan 6, 2025
Merged

#2270: External DB Support #2457

merged 11 commits into from
Jan 6, 2025

Conversation

DarioGii
Copy link
Contributor

@DarioGii DarioGii commented Dec 15, 2024 •
edited
Loading

Description

External DB support for Stirling PDF. You can now choose between the default H2 or PostgreSQL by setting the new enableCustomDatabase property to true or false.

To enable your own custom (PostgreSQL) database:

  • Set enableCustomDatabase to true
  • Add your database url to customDatabaseUrl
  • Set your username and password

Closes #2270

Checklist

  • I have read the Contribution Guidelines
  • I have performed a self-review of my own code
  • I have attached images of the change if it is UI based
  • I have commented my code, particularly in hard-to-understand areas
  • If my code has heavily changed functionality I have updated relevant docs on Stirling-PDFs doc repo
  • My changes generate no new warnings
  • I have read the section Add New Translation Tags (for new translation tags only)

@DarioGii DarioGii requested a review from Frooodle as a code owner December 15, 2024 13:20
@DarioGii DarioGii linked an issue Dec 15, 2024 that may be closed by this pull request
[Feature Request]: External DB support #2270
Closed
1 task
@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Dec 15, 2024
@github-actions github-actions bot added Java Pull requests that update Java code Front End Issues or pull requests related to front-end development Back End Issues related to back-end development Docker Pull requests that update Docker code Security Security-related issues or pull requests API API-related issues or pull requests labels Dec 15, 2024
@dosubot dosubot bot added the enhancement New feature or request label Dec 15, 2024
This was referenced Dec 15, 2024
Merged
Merged
@github-actions github-actions bot added Documentation Improvements or additions to documentation Translation Github labels Dec 20, 2024
@github-actions GitHub Actions
Copy link
Contributor

🚀 Translation Verification Summary

🔄 Reference Branch: pr-branch

📃 File Check: messages_ar_AR.properties

  1. Test Status: ✅ Passed
  2. Test Status: ✅ Passed

📃 File Check: messages_az_AZ.properties

  1. Test Status: ✅ Passed
  2. Test Status: ✅ Passed

📃 File Check: messages_bg_BG.properties

  1. Test Status: ✅ Passed
  2. Test Status: ✅ Passed

📃 File Check: messages_ca_CA.properties

  1. Test Status: ✅ Passed
  2. Test Status: ✅ Passed

📃 File Check: messages_cs_CZ.properties

  1. Test Status: ✅ Passed
  2. Test Status: ✅ Passed

📃 File Check: messages_da_DK.properties

  1. Test Status: ✅ Passed
  2. Test Status: ✅ Passed

📃 File Check: messages_de_DE.properties

  1. Test Status: ✅ Passed
  2. Test Status: ✅ Passed

📃 File Check: messages_el_GR.properties

  1. Test Status: ✅ Passed
  2. Test Status: ✅ Passed

📃 File Check: messages_en_US.properties

  1. Test Status: ✅ Passed
  2. Test Status: ✅ Passed

📃 File Check: messages_es_ES.properties

  1. Test Status: ✅ Passed
  2. Test Status: ✅ Passed

✅ Overall Check Status: Success

Thanks @DarioGii for your help in keeping the translations up to date.

@DarioGii DarioGii force-pushed the 2270-feature-request-external-db-support branch from d0e3ae9 to 46da009 Compare December 20, 2024 17:22
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:XL This PR changes 500-999 lines, ignoring generated files. labels Dec 20, 2024
@github-actions github-actions bot removed Documentation Improvements or additions to documentation Front End Issues or pull requests related to front-end development Docker Pull requests that update Docker code Translation API API-related issues or pull requests labels Dec 20, 2024
@DarioGii DarioGii force-pushed the 2270-feature-request-external-db-support branch 2 times, most recently from 6a764f9 to 22958ca Compare January 2, 2025 12:21
@DarioGii DarioGii force-pushed the 2270-feature-request-external-db-support branch 5 times, most recently from 6fb100e to 86514e9 Compare January 6, 2025 17:29
@DarioGii
Copy link
Contributor Author

DarioGii commented Jan 6, 2025

/deployr

@DarioGii DarioGii force-pushed the 2270-feature-request-external-db-support branch from 86514e9 to 88046df Compare January 6, 2025 18:01
@DarioGii
Copy link
Contributor Author

DarioGii commented Jan 6, 2025

/deployr

1 similar comment
@DarioGii
Copy link
Contributor Author

DarioGii commented Jan 6, 2025

/deployr

@DarioGii
Copy link
Contributor Author

DarioGii commented Jan 6, 2025

/deploypr

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 6, 2025

🚀 PR Test Deployment

Your PR has been deployed for testing!

🔗 Test URL: http://185.252.234.121:2457

This deployment will be automatically cleaned up when the PR is closed.

Frooodle
Frooodle requested changes Jan 6, 2025
View reviewed changes
build.gradle Outdated Show resolved Hide resolved
@DarioGii DarioGii force-pushed the 2270-feature-request-external-db-support branch from 652f43a to 55d4aed Compare January 6, 2025 18:40
@DarioGii DarioGii force-pushed the 2270-feature-request-external-db-support branch from 4c028c6 to 428b423 Compare January 6, 2025 18:49
@Frooodle Frooodle merged commit 41dce06 into main Jan 6, 2025
13 checks passed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 6, 2025

🧹 Deployment Cleanup

The test deployment for this PR has been cleaned up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Frooodle Frooodle Frooodle requested changes

@reecebrowne reecebrowne Awaiting requested review from reecebrowne reecebrowne is a code owner

@Ludy87 Ludy87 Awaiting requested review from Ludy87 Ludy87 is a code owner

Assignees
No one assigned
Labels
API API-related issues or pull requests Back End Issues related to back-end development Docker Pull requests that update Docker code enhancement New feature or request Front End Issues or pull requests related to front-end development Java Pull requests that update Java code Security Security-related issues or pull requests size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request]: External DB support
2 participants
@DarioGii @Frooodle