Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request]: External DB support #2270

Closed
1 task done
Frooodle opened this issue Nov 19, 2024 · 0 comments · Fixed by #2457
Closed
1 task done

[Feature Request]: External DB support #2270

Frooodle opened this issue Nov 19, 2024 · 0 comments · Fixed by #2457
Assignees
@DarioGii
Labels
enhancement New feature or request

Comments

@Frooodle
Copy link
Member

Frooodle commented Nov 19, 2024 •
edited
Loading

Feature Description

External DB support for security/ram optimisation and to allow multiple Stirling-PDF instances to be used along side load-balancer
Best to use PostgreSQL and its gradle dependency
Framework to add Oracle and MySQL easily if needed in future and should be done via the settings.yml

Why is this feature valuable?

External DB support for security/ram optimisation and to allow multiple Stirling-PDF instances to be used along side load-balancer

Suggested Implementation

No response

Additional Information

No response

No Duplicate of the Feature

  • I have verified that there are no existing features requests similar to my request.
@Frooodle Frooodle added the enhancement New feature or request label Nov 19, 2024
@Frooodle Frooodle moved this to Next to pickup in Stirling-PDF V1 Nov 19, 2024
@Frooodle Frooodle moved this from Next to pickup to In Progress in Stirling-PDF V1 Dec 3, 2024
DarioGii added a commit that referenced this issue Dec 5, 2024
@DarioGii
#2270 wip
ffed0cc
DarioGii added a commit that referenced this issue Dec 6, 2024
@DarioGii
#2270 added initDB script
ce74982
DarioGii added a commit that referenced this issue Dec 8, 2024
@DarioGii
#2270 added initDB script
6255177
DarioGii added a commit that referenced this issue Dec 8, 2024
@DarioGii
#2270 config for DB variants
519e4ff
DarioGii added a commit that referenced this issue Dec 10, 2024
@DarioGii
#2270 cleanup
96d04f2
DarioGii added a commit that referenced this issue Dec 10, 2024
@DarioGii
#2270 adding postgres to Docker
50de87b
DarioGii added a commit that referenced this issue Dec 10, 2024
@DarioGii
#2270 added initDB script
d0e3846
DarioGii added a commit that referenced this issue Dec 10, 2024
@DarioGii
#2270 config for DB variants
69db8b0
DarioGii added a commit that referenced this issue Dec 10, 2024
@DarioGii
#2270 cleanup
b505e56
DarioGii added a commit that referenced this issue Dec 10, 2024
@DarioGii
#2270 adding postgres to Docker
c7f7327
DarioGii added a commit that referenced this issue Dec 10, 2024
@DarioGii
#2270 adding postgres to default profile
1d9342c
DarioGii added a commit that referenced this issue Dec 11, 2024
@DarioGii
#2270 added initDB script
26c7074
DarioGii added a commit that referenced this issue Dec 11, 2024
@DarioGii
#2270 config for DB variants
cd9776e
DarioGii added a commit that referenced this issue Dec 11, 2024
@DarioGii
#2270 cleanup
a43ed7c
DarioGii added a commit that referenced this issue Dec 11, 2024
@DarioGii
#2270 adding postgres to Docker
7434506
DarioGii added a commit that referenced this issue Dec 11, 2024
@DarioGii
#2270 adding postgres to default profile
1d741a5
DarioGii added a commit that referenced this issue Dec 12, 2024
@DarioGii
#2270 added initDB script
4694d3b
DarioGii added a commit that referenced this issue Dec 12, 2024
@DarioGii
#2270 config for DB variants
762e1d3
DarioGii added a commit that referenced this issue Dec 12, 2024
@DarioGii
#2270 cleanup
e99f900
DarioGii added a commit that referenced this issue Dec 12, 2024
@DarioGii
#2270 adding postgres to Docker
c5e1b97
DarioGii added a commit that referenced this issue Dec 12, 2024
@DarioGii
#2270 adding postgres to default profile
55fa77e
DarioGii added a commit that referenced this issue Dec 12, 2024
@DarioGii
#2270 added initDB script
e9bc3de
DarioGii added a commit that referenced this issue Dec 12, 2024
@DarioGii
#2270 config for DB variants
1e8dff2
DarioGii added a commit that referenced this issue Dec 12, 2024
@DarioGii
#2270 cleanup
aeb8d0a
DarioGii added a commit that referenced this issue Dec 12, 2024
@DarioGii
#2270 adding postgres to Docker
7c4bf87
DarioGii added a commit that referenced this issue Dec 13, 2024
@DarioGii
#2270 configuring host
7abbc3a
DarioGii added a commit that referenced this issue Dec 14, 2024
@DarioGii
#2270 added initDB script
564c11a
DarioGii added a commit that referenced this issue Dec 14, 2024
@DarioGii
#2270 config for DB variants
fcdb3fb
DarioGii added a commit that referenced this issue Dec 14, 2024
@DarioGii
#2270 cleanup
09e2799
DarioGii added a commit that referenced this issue Dec 14, 2024
@DarioGii
#2270 adding postgres to Docker
7bdb479
DarioGii added a commit that referenced this issue Dec 14, 2024
@DarioGii
#2270 adding postgres to default profile
4f6d121
DarioGii added a commit that referenced this issue Dec 14, 2024
@DarioGii
#2270 configuring host
591bd8a
DarioGii added a commit that referenced this issue Dec 14, 2024
@DarioGii
#2270 configuring host
7d742a0
DarioGii added a commit that referenced this issue Dec 14, 2024
@DarioGii
#2270 adding postgres to default profile
8de89fc
DarioGii added a commit that referenced this issue Dec 15, 2024
@DarioGii
#2270 updating other Docker configs
863a6e5
@DarioGii DarioGii linked a pull request Dec 15, 2024 that will close this issue
#2270: External DB Support #2457
Merged
7 tasks
DarioGii added a commit that referenced this issue Dec 15, 2024
@DarioGii
#2270 cleanup
6425930
DarioGii added a commit that referenced this issue Dec 15, 2024
@DarioGii
#2270 a little more cleanup
841ad62
DarioGii added a commit that referenced this issue Dec 20, 2024
@DarioGii
#2270: Adding comments
fd0159d
DarioGii added a commit that referenced this issue Dec 20, 2024
@DarioGii
#2270: wip
de6a66e
DarioGii added a commit that referenced this issue Dec 20, 2024
@DarioGii
#2270: wip - settings.yml not being read for some classes?
f072de8
DarioGii added a commit that referenced this issue Dec 22, 2024
@DarioGii
#2270: updating docker-compose files
3918a5e
DarioGii added a commit that referenced this issue Dec 22, 2024
@DarioGii
#2270: clean up
7dad36c
DarioGii added a commit that referenced this issue Dec 22, 2024
@DarioGii
#2270: clean up
2ec6c98
DarioGii added a commit that referenced this issue Dec 30, 2024
@DarioGii
#2270: renamed datasource config flag
b21d45e
DarioGii added a commit that referenced this issue Jan 1, 2025
@DarioGii
#2270 moving db container to a separate compose file
b89b73e
DarioGii added a commit that referenced this issue Jan 6, 2025
@DarioGii
#2270 moving db container to a separate compose file
d3525eb
@DarioGii DarioGii mentioned this issue Jan 6, 2025
Merged
7 tasks
DarioGii added a commit that referenced this issue Jan 6, 2025
@DarioGii
#2270 moving db container to a separate compose file
c97d731
DarioGii added a commit that referenced this issue Jan 6, 2025
@DarioGii
#2270 moving db container to a separate compose file
a3e2b1a
DarioGii added a commit that referenced this issue Jan 6, 2025
@DarioGii
#2270 moving db container to a separate compose file
7d71fd0
Frooodle pushed a commit that referenced this issue Jan 6, 2025
@DarioGii
#2270: External DB Support (#2457)
41dce06 
# Description

External DB support for Stirling PDF. You can now choose between the
default H2 or PostgreSQL by setting the new `enableCustomDatabase`
property to `true` or `false`.

To enable your own custom (PostgreSQL) database:
- Set `enableCustomDatabase` to `true`
- Add your database url to `customDatabaseUrl`
- Set your `username` and `password`

Closes #2270 

## Checklist

- [x] I have read the [Contribution
Guidelines](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/CONTRIBUTING.md)
- [x] I have performed a self-review of my own code
- [x] I have attached images of the change if it is UI based
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] If my code has heavily changed functionality I have updated
relevant docs on [Stirling-PDFs doc
repo](https://github.com/Stirling-Tools/Stirling-Tools.github.io/blob/main/docs/)
- [x] My changes generate no new warnings
- [x] I have read the section [Add New Translation
Tags](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/HowToAddNewLanguage.md#add-new-translation-tags)
(for new translation tags only)
@github-project-automation github-project-automation bot moved this from In Progress to Done in Stirling-PDF V1 Jan 6, 2025
@DarioGii DarioGii mentioned this issue Jan 7, 2025
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DarioGii DarioGii

Labels
enhancement New feature or request
Projects
Stirling-PDF V1
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#2270: External DB Support Stirling-Tools/Stirling-PDF
2 participants
@DarioGii @Frooodle