chore: cleanup CMakePresets.json, add Ninja configs #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThirdEyeSqueegee
merged commit 642c52b
into
Starfield-Reverse-Engineering:main
3 checks passed
gottyduke
added a commit
to gottyduke/CMakeLibSF
that referenced
this pull request
Sep 9, 2023
gottyduke
added a commit
to gottyduke/CMakeLibSF
that referenced
this pull request
Sep 9, 2023
gottyduke
added a commit
that referenced
this pull request
Sep 9, 2023
1. Removed `/FI` force include directive flag to accommodate recent [vcpkg port update](https://github.com/Starfield-Reverse-Engineering/Starfield-RE-vcpkg/). This addresses the redefinition error when compiling project with a clean commonblisf vcpkg package. 2. Reverted some notable changes in #19 , see below. --- Changes reverted: In [CommonLibSF/CMakePresets.json](https://github.com/Starfield-Reverse-Engineering/CommonLibSF/compare/main...gottyduke:CommonLibSF:main?expand=1#diff-6d621fcc34a299795af75ba4026fa929d2b8b506efda705e332cf7dd06e6904f): ```json { "name": "buildtype-debug-msvc", "hidden": true, "cacheVariables": { "CMAKE_BUILD_TYPE": "Debug", "CMAKE_CXX_FLAGS_DEBUG": "/Od /MDd", "CMAKE_SHARED_LINKER_FLAGS_DEBUG": "/DEBUG:FULL /LTCG:INCREMENTAL /DEBUGTYPE:FIXUP" } } ``` Specifying `/LTCG:INCREMENTAL` for a debug build with `/Od` doesn't make sense here, `/LTCG` would imply `/GL` and `/Od` disables all optimizations. The other reason is that `/LTCG` flag is **explicitly** turned off for debug build with ```cmake set(CMAKE_INTERPROCEDURAL_OPTIMIZATION ON) set(CMAKE_INTERPROCEDURAL_OPTIMIZATION_DEBUG OFF) ``` Then the `/MDd` flag is also redundant, this has been specified with ```cmake "CMAKE_MSVC_RUNTIME_LIBRARY": "MultiThreaded$<$<CONFIG:Debug>:Debug>DLL" ``` Othe occurrences of `/LTCG` and `/MDd`/`/MTd` has been removed for the same reason. `/MACHINE:x64` has been removed for linker flag, this is unnecessary. configurePresets and buildPresets have added the `<config>-clang-cl-msvc` variants, for generating a **visual studio** solution with ClangCL toolset. --- Fixes added for #19 : Updated the batch files to reflect the above CMakePresets.json changes. --- closes #22 --------- Co-authored-by: maintenance <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.