-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix!: remove /FI
(#22) and revert some changes in #19
#23
Conversation
Should keep the |
Yes it's enabled with the same statements set(CMAKE_INTERPROCEDURAL_OPTIMIZATION ON)
set(CMAKE_INTERPROCEDURAL_OPTIMIZATION_DEBUG OFF) This is written in CMakeLists.txt, if you feel the need to change it, then you could still append them in the CMakePresets.json |
I don't think the CMake command sets |
|
Nice! TIL 😁 |
Correct me if I did it wrong, feel free to fix any bug if I brought them in. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM besides the (accidental?) CMakePresets schema version change
Again regarding the |
"For even faster performance, use
EDIT: Apparently it's safer to use regular |
/FI
force include directive flag to accommodate recent vcpkg port update. This addresses the redefinition error when compiling project with a clean commonblisf vcpkg package.Changes reverted:
In CommonLibSF/CMakePresets.json:
Specifying
/LTCG:INCREMENTAL
for a debug build with/Od
doesn't make sense here,/LTCG
would imply/GL
and/Od
disables all optimizations. The other reason is that/LTCG
flag is explicitly turned off for debug build withThen the
/MDd
flag is also redundant, this has been specified withOthe occurrences of
/LTCG
and/MDd
//MTd
has been removed for the same reason./MACHINE:x64
has been removed for linker flag, this is unnecessary.configurePresets and buildPresets have added the
<config>-clang-cl-msvc
variants, for generating a visual studio solution with ClangCL toolset.Fixes added for #19 :
Updated the batch files to reflect the above CMakePresets.json changes.
closes #22