Open
Conversation
TheBusyBiscuit
requested changes
Aug 6, 2021
dough-data/src/test/java/io/github/bakedlibs/dough/collections/DummyData.java
Outdated
Show resolved
Hide resolved
dough-data/src/test/java/io/github/bakedlibs/dough/collections/TestCopyUtils.java
Outdated
Show resolved
Hide resolved
dough-data/src/test/java/io/github/bakedlibs/dough/collections/TestCopyUtils.java
Outdated
Show resolved
Hide resolved
…into tests/copy-utils
|
Kudos, SonarCloud Quality Gate passed!
|
TheBusyBiscuit
requested changes
Aug 8, 2021
Comment on lines
+29
to
+41
| private static <T> void assertHaveClonedElements(@Nonnull Collection<T> c1, @Nonnull Collection<T> c2) { | ||
| Assertions.assertEquals(c1.size(), c2.size()); | ||
| for (T t1 : c1) { | ||
| for (T t2 : c2) { | ||
| // If they are the same, it did not clone and thus we fail. | ||
| Assertions.assertNotSame(t1, t2); | ||
| if (t1.equals(t2)) { | ||
| // If they are equal, the element has been cloned, thus, we break and check the next element. | ||
| break; | ||
| } | ||
| } | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
Collections can be unordered, making this fail. This implementations only works for ordered/sorted collections, aka Lists.
Contributor
Author
There was a problem hiding this comment.
Why would this fail if it was unordered? Maybe I'm just very sleepy but I can't seem to think of why this would fail if it wasn't ordered
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #61