Conversation
…into tests/dough-data
md5sha256
force-pushed
the
tests/dough-data
branch
from
ea27e23 to
13b419c
Compare
|
Kudos, SonarCloud Quality Gate passed! |
Contributor
|
Marking this as stale |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Waiting on #62 to be merged as this includes the tests for
CopyUtils.Whilst the PR has enough tests, there is room for improvement in the quality and (potentially) necessary documentation of the tests.
This PR adds tests for the
blocksandcollectionspackages in dough data alongsidedata.TriStateOptional. ~~That being said, there aren't any tests for the persistence package. ~~I'm hoping once MockBukkit/MockBukkit#244 is merged I can start working on writing tests for
PersistentDataAPI.I haven't added
@Displaynameannotations to the tests consistently but there are a few which do have them.This brings us up to 88% class coverage and 75% lines covered.