Skip to content

Commit

Permalink
misc jenkins fixups (commaai#24840)
Browse files Browse the repository at this point in the history
* bump cereal

* remove that

* pull cl image

* lil docker cleanup
  • Loading branch information
adeebshihadeh authored Jun 13, 2022
1 parent 1c29b20 commit 39da691
Show file tree
Hide file tree
Showing 5 changed files with 10 additions and 19 deletions.
7 changes: 1 addition & 6 deletions Dockerfile.openpilot
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,6 @@ ENV PYTHONPATH ${OPENPILOT_PATH}:${PYTHONPATH}
RUN mkdir -p ${OPENPILOT_PATH}
WORKDIR ${OPENPILOT_PATH}

COPY Pipfile Pipfile.lock $OPENPILOT_PATH
RUN pip install --no-cache-dir pipenv==2021.5.29 pip==21.3.1 && \
pipenv install --system --deploy --dev --clear && \
pip uninstall -y pipenv

COPY SConstruct ${OPENPILOT_PATH}

COPY ./pyextra ${OPENPILOT_PATH}/pyextra
Expand All @@ -30,4 +25,4 @@ COPY ./panda ${OPENPILOT_PATH}/panda
COPY ./selfdrive ${OPENPILOT_PATH}/selfdrive
COPY ./system ${OPENPILOT_PATH}/system

RUN scons -j$(nproc)
RUN scons --cache-readonly -j$(nproc)
2 changes: 1 addition & 1 deletion cereal
8 changes: 2 additions & 6 deletions selfdrive/manager/test/test_manager.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,13 @@
import unittest

import selfdrive.manager.manager as manager
from system.hardware import AGNOS, HARDWARE
from selfdrive.manager.process import DaemonProcess
from selfdrive.manager.process_config import managed_processes
from system.hardware import AGNOS, HARDWARE

os.environ['FAKEUPLOAD'] = "1"

# TODO: make eon fast
MAX_STARTUP_TIME = 15
MAX_STARTUP_TIME = 3
ALL_PROCESSES = [p.name for p in managed_processes.values() if (type(p) is not DaemonProcess) and p.enabled and (p.name not in ['updated', 'pandad'])]


Expand Down Expand Up @@ -54,9 +53,6 @@ def test_clean_exit(self):
# TODO: make Qt UI exit gracefully
continue

# Make sure the process is actually dead
managed_processes[p].stop()

# TODO: interrupted blocking read exits with 1 in cereal. use a more unique return code
exit_codes = [0, 1]
if managed_processes[p].sigkill:
Expand Down
10 changes: 5 additions & 5 deletions tools/sim/Dockerfile.sim
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
FROM ghcr.io/commaai/openpilot-base-cl:latest

RUN apt-get update && apt-get install -y --no-install-recommends\
tmux \
vim \
&& rm -rf /var/lib/apt/lists/*
RUN apt-get update && apt-get install -y --no-install-recommends \
tmux \
vim \
&& rm -rf /var/lib/apt/lists/*

# get same tmux config used on NEOS for debugging
RUN cd $HOME && \
Expand All @@ -27,6 +27,6 @@ COPY ./system $HOME/openpilot/system
COPY ./tools $HOME/openpilot/tools

WORKDIR $HOME/openpilot
RUN scons -j12
RUN scons --cache-readonly -j12

RUN python -c "from selfdrive.test.helpers import set_params_enabled; set_params_enabled()"
2 changes: 1 addition & 1 deletion tools/sim/build_container.sh
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
cd $DIR/../../

docker pull ghcr.io/commaai/openpilot-base:latest
docker pull ghcr.io/commaai/openpilot-base-cl:latest
docker build \
--cache-from ghcr.io/commaai/openpilot-sim:latest \
-t ghcr.io/commaai/openpilot-sim:latest \
Expand Down

0 comments on commit 39da691

Please sign in to comment.