-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
logs v4 qb refactor #5908
logs v4 qb refactor #5908
Conversation
Can we get rid of v3 in logs after v4 is fully rolled out? |
Yeah once it is fully rolled out, we will stop ingestion for the old table and the entire v3 code can be removed, some functions will have to be moved to the new folder that we are reusing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments
Mostly LGTM. @raj-k-singh please review |
@raj-k-singh feel free to leave a comment if you find something, I have merged it as I want to move ahead with other PRs for the feature. |
I gave the PR a quick look and everything seemed ok to me |
For #5555 , second PR . Follow up of #5872
Changes made code wise
In v3 folder
json_filter.go
,json_filter_test.go
,query_builder.go
Some functions and constants are made public in these files and no other change.
In v4 folder
json_filter.go
andjson_filter_test.go
The only change for these two files is that the map
jsonLogOperators
usesLIKE
instead ofILIKE
. So the functionGetJSONFilter
is a local one and no change apart from that.In v4 folder
query_builder.go
andquery_builder_test.go