Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: logs list API, logic update for better perf #5912

Merged
merged 15 commits into from
Sep 12, 2024

Conversation

nityanandagohain
Copy link
Member

@nityanandagohain nityanandagohain commented Sep 10, 2024

Improved logic in list api for better perf

Follow up of #5908

For issue #5555

Logic:

  • Look for 100 logs in the last one hour X.
  • If not found look for log in X-3 to X-1 hour.
  • Keep looking back until sufficient data is found or it reaches timestamp start.

Note the same logic and test is repeated in querierV2

@github-actions github-actions bot added the enhancement New feature or request label Sep 10, 2024
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@nityanandagohain nityanandagohain marked this pull request as ready for review September 12, 2024 08:38
Copy link
Member

@srikanthccv srikanthccv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does logs context work going forward?

pkg/query-service/app/querier/querier.go Show resolved Hide resolved
pkg/query-service/app/querier/querier.go Show resolved Hide resolved
pkg/query-service/app/querier/v2/querier.go Outdated Show resolved Hide resolved
@nityanandagohain
Copy link
Member Author

No changes on the backend w.r.t logs context. On the frontend as of now order by is timestamp, we will add id as well in the order by. It's a non blocker.

Copy link
Member

@srikanthccv srikanthccv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One main question around the id

pkg/query-service/app/querier/querier.go Show resolved Hide resolved
pkg/query-service/app/querier/v2/querier.go Outdated Show resolved Hide resolved
@nityanandagohain nityanandagohain merged commit 90b5f88 into develop Sep 12, 2024
13 checks passed
@nityanandagohain nityanandagohain deleted the feat/v4-logs-list branch September 12, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants