Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: added default fallback for selectedColumns, when the attributeKeys call gives empty #5847

Merged
merged 3 commits into from
Sep 6, 2024
Merged

fix: added default fallback for selectedColumns, when the attributeKeys call gives empty #5847

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0b8f722
fix: added default fallback for selectedColumns, when the attributeKe…
SagarRajput-7 Sep 4, 2024
ba7de17
Merge branch 'develop' into SIG-1459
SagarRajput-7 Sep 6, 2024
e70ead4
Merge branch 'develop' into SIG-1459
SagarRajput-7 Sep 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions frontend/src/container/OptionsMenu/useOptionsMenu.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,11 @@ const useOptionsMenu = ({
return col;
})
.filter(Boolean) as BaseAutocompleteData[];

// this is the last point where we can set the default columns and if uptil now also we have an empty array then we will set the default columns
if (!initialSelected || !initialSelected?.length) {
initialSelected = defaultTraceSelectedColumns;
}
}

return initialSelected || [];
Expand Down
Loading